Thunks: Fix definition of GUEST_THUNK_LIBRARY

The -deps target is the wrong target to add this to, since its compile flags
are propagated to both Guest.cpp and Host.cpp. Instead, define the flag only
when processing files within a guest context.

ThunkLibs/Generator/main.cpp

@@ -77,6 +77,7 @@ int main(int argc, char* const argv[]) {
             AdjustedArgs.push_back(std::string { "--target=" } + platform + "-linux-unknown");
             AdjustedArgs.push_back("-isystem");
             AdjustedArgs.push_back(std::string { "/usr/" } + platform + "-linux-gnu/include/");
+            AdjustedArgs.push_back("-DGUEST_THUNK_LIBRARY");
             return AdjustedArgs;
         };
         GuestTool.appendArgumentsAdjuster(append_guest_args);

ThunkLibs/GuestLibs/CMakeLists.txt

@@ -51,7 +51,6 @@ function(generate NAME SOURCE_FILE)
   # Interface target for the user to add include directories
   add_library(${NAME}-guest-deps INTERFACE)
   target_include_directories(${NAME}-guest-deps INTERFACE "${CMAKE_CURRENT_SOURCE_DIR}/../include")
-  target_compile_definitions(${NAME}-guest-deps INTERFACE GUEST_THUNK_LIBRARY)
   if (BITNESS EQUAL 32)
     target_compile_definitions(${NAME}-guest-deps INTERFACE IS_32BIT_THUNK)
   endif ()

ThunkLibs/libfex_thunk_test/Host.cpp

@@ -13,6 +13,7 @@ tags: thunklibs|fex_thunk_test
 
 #include "thunkgen_host_libfex_thunk_test.inl"
 
+static_assert(offsetof(ReorderingType, a) == 0);
 static uint32_t fexfn_impl_libfex_thunk_test_QueryOffsetOf(guest_layout<ReorderingType*> data, int index) {
     if (index == 0) {
         return offsetof(guest_layout<ReorderingType>::type, a);

unittests/FEXLinuxTests/tests/thunks/thunk_testlib.cpp

@@ -1,3 +1,5 @@
+#define GUEST_THUNK_LIBRARY
+
 #include <dlfcn.h>
 
 #include <stdexcept>