Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused TODO block for IFS currents coupling #490

Merged
merged 3 commits into from
Aug 23, 2023
Merged

remove unused TODO block for IFS currents coupling #490

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64093df
remove unused TODO block for currents coupling
Aug 22, 2023
224e468
remove some "done" comments
Aug 22, 2023
d376f74
fix misleading message about fesom abort
Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 13 additions & 61 deletions src/ifs_interface/ifs_interface.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,50 +575,6 @@ SUBROUTINE nemogcmcoup_lim2_get( mype, npes, icomm, &
nfield = nfield + 1
pgvcur(:) = zrecvnf(:,nfield)

! Pack u(v) surface currents on elements
!zsendnfUV(:,1)=fesom%dynamics%UV(1,1,1:myDim_elem2D)
!zsendnfUV(:,2)=fesom%dynamics%UV(2,1,1:myDim_elem2D) !UV includes eDim, leave those away here
!nfielduv = 2
!
!do elem=1, myDim_elem2D
!
! ! compute element midpoints
! elnodes=elem2D_nodes(:,elem)
! rlon=sum(coord_nod2D(1,elnodes))/3.0_wpIFS
! rlat=sum(coord_nod2D(2,elnodes))/3.0_wpIFS
!
! ! Rotate vectors to geographical coordinates (r2g)
! CALL vector_r2g(zsendnfUV(elem,1), zsendnfUV(elem,2), rlon, rlat, 0) ! 0-flag for rot. coord
!
!end do

#ifdef FESOM_TODO

! We need to sort out the non-unique global index before we
! can couple currents

! Interpolate: 'pgucur' and 'pgvcur' on Gaussian grid.
IF (lparintmultatm) THEN
CALL parinter_fld_mult( nfielduv, mype, npes, icomm, UVtogauss, &
& myDim_nod2D, zsendnfUV, &
& nopoints, zrecvnfUV )
ELSE
DO jf = 1, nfielduv
CALL parinter_fld( mype, npes, icomm, UVtogauss, &
& myDim_nod2D, zsendnfUV(:,jf), &
& nopoints, zrecvnfUV(:,jf) )
ENDDO
ENDIF
pgucur(:) = zrecvnfUV(:,1)
pgvcur(:) = zrecvnfUV(:,2)

#else

!pgucur(:) = 0.0
!pgvcur(:) = 0.0

#endif

END SUBROUTINE nemogcmcoup_lim2_get


Expand Down Expand Up @@ -862,24 +818,20 @@ SUBROUTINE nemogcmcoup_lim2_update( mype, npes, icomm, &
! Sort out incoming arrays from the IFS and put them on the ocean grid

! TODO
shortwave(:)=0. ! Done, updated below. What to do with shortwave over ice??
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trackow is this all solved as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there are no open questions really in the coupling. Just make sure that the resetting to 0 is still happening here, the comments can go

!longwave(:)=0. ! Done. Only used in stand-alone mode.
prec_rain(:)=0. ! Done, updated below.
prec_snow(:)=0. ! Done, updated below.
evap_no_ifrac=0. ! Done, updated below. This is evap over ocean, does this correspond to evap_tot?
sublimation=0. ! Done, updated below.
shortwave(:)=0.
!longwave(:)=0.
prec_rain(:)=0.
prec_snow(:)=0.
evap_no_ifrac=0.
sublimation=0.
!
ice_heat_flux=0. ! Done. This is qns__ice currently. Is this the non-solar heat flux? ! non solar heat fluxes below ! (qns)
oce_heat_flux=0. ! Done. This is qns__oce currently. Is this the non-solar heat flux?
ice_heat_flux=0.
oce_heat_flux=0.
!
!runoff(:)=0. ! not used apparently. What is runoffIN, ocerunoff?
!evaporation(:)=0.
!ice_thermo_cpl.F90: !---- total evaporation (needed in oce_salt_balance.F90)
!ice_thermo_cpl.F90: evaporation = evap_no_ifrac*(1.-a_ice) + sublimation*a_ice
stress_atmice_x=0. ! Done, taux_ice
stress_atmice_y=0. ! Done, tauy_ice
stress_atmoce_x=0. ! Done, taux_oce
stress_atmoce_y=0. ! Done, tauy_oce
stress_atmice_x=0.
stress_atmice_y=0.
stress_atmoce_x=0.
stress_atmoce_y=0.

! =================================================================== !
! Pack all arrays
Expand Down Expand Up @@ -1187,4 +1139,4 @@ SUBROUTINE nemogcmcoup_final
endif
CALL fesom_finalize

END SUBROUTINE nemogcmcoup_final
END SUBROUTINE nemogcmcoup_final