remove unused TODO block for IFS currents coupling #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianbeyer
commented
Aug 22, 2023
| @@ -862,24 +818,20 @@ SUBROUTINE nemogcmcoup_lim2_update( mype, npes, icomm, & | |||
| ! Sort out incoming arrays from the IFS and put them on the ocean grid | |||
|
|
|||
| ! TODO | |||
| shortwave(:)=0. ! Done, updated below. What to do with shortwave over ice?? | |||
There was a problem hiding this comment.
@trackow is this all solved as well?
There was a problem hiding this comment.
Yes, there are no open questions really in the coupling. Just make sure that the resetting to 0 is still happening here, the comments can go
|
I also changed the misleading abort message here, fits the context. |
|
Maybe @dsidoren could take a look and then this can be merged? |
|
Or @koldunovn ? |
koldunovn
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.