refactoring with icebergs #489
Conversation
…code on gitlab wiso branch
|
Hello @ackerlar, thank you for putting this PR together. Quite a big one! I did a scan of the PR, and I would recommend a general cleanup of
I found one line where the oifs and ifs setups were inadvertently modified. Besides that the merge conflicts have to be resolved of course. Overall a great step forward. Let me know if you have some questions / would like some help. I'd happily sit together for an our or so, getting this one on track. |
|
I had a quick chat about this one with @patrickscholz. Most of the merge conflicts are trivial. Only the one in src/fesom_module.F90 looks to be a bit more complex. Maybe you can do the others ones yourself, and if you get stuck with src/fesom_module.F90, Patrick or me try to help out. |
|
All checks seem to work with the latest commit. Is there anything I need to do now? |
You still need to request a review. |
|
@trackow: Is there the possibility that you test this branch if it compiles with IFS, just to be sure we dont fuck anything up when we merge ! |
paleo features + fix for freshwater scaling
…r/fesom2 into tmp_refactoring_with_icb
No description provided.