-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transient Tracers #572
Transient Tracers #572
Conversation
…sea ice; sea ice delta values now passed to ECHAM atmosphere model; minor code cleanup
…ral minor code improvements
…use of water isotope tracers and other tracers; minor code cleanup
Conflicts: src/ice_oce_coupling.F90
- FESOM2.0 simulations on AWI ollie HPC were not always reproducible. Runs with identical namelists, init-conditions ... could lead to sligthly different results. - Natalja solved that issue by changing the compiler flag -fast-transcendentals with -fimf-use-svml - with this option loops with exp, sin, cos ... (IEEE function) will be always computed through the vector implementation otherwise the compiler is not fixed how IEEE funtions should be treated, which can be either Vector, Scalar or something else. All three can give slightly different results
…SOM/fesom2 into paleodyn/awiesm-2.1-gamma
This namelist file is obsolete (as all namelist switches necessary for transient tracers are included in namelist.config now).
Remove dated path to tracer input file ifile_transit.
This namelist file has become obsolete.
Update comment on the file name of ifile_transit.
This file has become obsolete for transient tracer simulations.
Update and fix settings for transient tracers.
This namelist has become obsolete for transient tracer simulations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namelist.io.transit can be removed but namelist.io has to include 'otracers' in transient tracers simulations.
Checked ... Go ahead, @JanStreffing! |
@mbutzin and I had a look at this and came to the conclusion, that many of the code changes and subsequent MR conflicts result from the older realization of iceberg and wiso. Both have today been mergen in a newer version via: #489 I will try to rebase Martins tracer code on top of the current refactoring branch instead. This would result in a much smaller MR. |
Here is the preliminary result with a simple git patch:
While that is more reject than clean applications, I can already tell from the low number of files affected, that this seems quite doable. @mbutzin Tomorrow we sit down with you to make this happen. I think we can manage the resulting MR for 2.6. |
superseded by #576 |
I checkout out https://github.com/FESOM/fesom2/tree/2.1-awiesm-2.1-with-transient-tracers and did a git revert on the critical commit fb6eab8.
The result is, that the MR reduces from 279 changes files to 42 changed files, and from +62,015 −116,851 lines to a much more manageable +8,685 −150. A plenitude of conflicts remain though.
@mbutzin, please have a look if this branch still constitutes a working tracers branch, or if undoing that commit anything critical got lost. Note that no src/ files were changed, but lots of namelists were.