feat: edge-to-edge mode on Android #52392

kirillzyusko · 2024-11-12T13:51:38Z

Explanation of Change

Fixed Issues

$ #51673
$ #52116
PROPOSAL: #52116 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

kirillzyusko · 2024-11-12T15:56:51Z

@shawnborton would it be possible to ask you to test this PR? This PR should unify how Android app is handling insets (now it'll be identical to iOS). This PR is a logical continuation of this #51956 but the key difference is that now we don't manage color of navigation bar independtly - now we make all system bars (navigation bar, status bar) transparent by default, so it matches iOS app style.

The reason why I want you to test and give your feedback, is because some elements look good on iOS, but looks not very good on Android. For example, navigation bar padding on Android vs iOS:

Coefficient	Android	iOS
0.7 (default for iOS)
1

This is the one issue I spotted at the moment, but maybe you find more - your feedback is very valuable 🙏

@mountiny would it be possible to trigger a build so that @shawnborton can test the app?

shawnborton · 2024-11-12T15:59:16Z

I can trigger a test build. I don't have an Android with me at the moment but I believe @dubielzyk-expensify can help us test!

kirillzyusko · 2024-11-12T16:10:54Z

but I believe @dubielzyk-expensify can help us test!

Sounds good! Any look from UX/UI team will help a lot ❤️

shawnborton · 2024-11-12T16:26:43Z

We might need to take the PR out of draft in order to run the test build. If we don't get a test build posted in the next 20 minutes or so, let's try that.

shawnborton · 2024-11-12T16:30:02Z

Well wouldya just look at that, ready for testing.

mountiny · 2024-11-12T18:03:12Z

Assigned @c3024 for c+ review

dubielzyk-expensify · 2024-11-13T01:38:38Z

Tested this on Android now. Definitely agree with this comment that we should add some tiny padding above the home indicator. Scenarios where we use cards get a bit weird so hopefully that'll fix this too:

I'm not sure exactly where the padding is applied, but the footer buttons seem to get excessive padding on some screens:

Other than that, this is looking good.

I think in an ideal world, I'd prefer both home indicators on iOS and Android to be transparent instead of using appBg color, but that's probably a separate PR and issue altogether.

shawnborton · 2024-11-13T08:05:37Z

Nice testing Jon, thanks for running through the screens and I agree with your feedback.

kirillzyusko · 2024-11-13T09:18:51Z

Awesome @dubielzyk-expensify ! 🔥 Thank you for your feedback!

mountiny · 2024-11-13T19:26:32Z

Do we need a new build @kirillzyusko

kirillzyusko · 2024-11-13T19:27:52Z

@mountiny no, not yet. Tomorrow I want to test on more devices and if everything works well, then I will ask for additional testing 😊

kirillzyusko · 2024-11-14T12:06:33Z

package.json

@@ -113,6 +113,7 @@
    "expo-av": "14.0.7",
    "expo-image": "1.12.15",
    "expo-image-manipulator": "12.0.5",
+    "expo-navigation-bar": "~3.0.7",


I had to add this library again, because we need to manage navigation bar button style (dark/light).

Since user can customize the theme of app independently to device settings we also have to manage it dynamically from JS code.

I checked and one method that we use (setButtonStyleAsync) doesn't use deprecated API. However I remember, that this particular library wasn't accepted in the first round of fixing the nav bar color management, so i'm happy to discuss further steps here 🙌

kirillzyusko · 2024-11-14T14:10:22Z

@mountiny I believe this PR is ready for another round of review 🙂 Can you trigger a build and can we ask @dubielzyk-expensify to have a look again? If everything is alright then can we ask QA to test this PR before merge? 👀

shawnborton · 2024-11-14T14:20:11Z

I can fire up the build 🚀

kirillzyusko · 2024-11-14T14:21:56Z

I can fire up the build 🚀

Thank you 🙌

github-actions · 2024-11-14T14:47:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52392/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/52392/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52392/NewExpensify.dmg	https://52392.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dubielzyk-expensify · 2024-11-15T02:52:58Z

Checked this on Android and it looks great now 👍 The web build don't work though so I can't test that one.

c3024

Few NITs.

I am testing it now. Will update if I find anything.

src/libs/Navigation/AppNavigator/AuthScreens.tsx

src/styles/theme/types.ts

src/styles/utils/index.ts

c3024 · 2024-11-15T06:06:27Z

I am seeing a gap below the chat with these steps.

Kill the app.
Open the app.
Login with a new email.
Complete the onboarding flow.
There is a gap between the bottom of the chat composer. (as if the on screen keyboard opened partially.)

I can reproduce this on Redmi Note 11 Pro+ and Samsung F23 devices 4 out of 5 times. This works well on main.

edgeGapUnderChat-compressed.mp4

kirillzyusko · 2024-11-15T13:10:19Z

The web build don't work though so I can't test that one.

Thanks! I fixed it in e718209

github-actions · 2024-11-15T13:59:02Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

kirillzyusko · 2024-11-15T14:16:21Z

I can reproduce this on Redmi Note 11 Pro+ and Samsung F23 devices 4 out of 5 times. This works well on main.

I could reproduce it as well (but it's reproducible only in release variant). I have a fix in my head, but the development of fix will take more time, because I have constantly test on release variant 🙈 I think I'll fix it on Monday!

github-actions · 2024-11-15T14:26:50Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52392/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/52392/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52392/NewExpensify.dmg	https://52392.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

kirillzyusko · 2024-11-18T10:31:47Z

I can reproduce this on Redmi Note 11 Pro+ and Samsung F23 devices 4 out of 5 times. This works well on main.

Fixed it in 842ac00

c3024 · 2024-11-18T10:54:04Z

Thanks!

@Julesssss @mountiny

Could you trigger a build here? It will make it easier for me to test on multiple devices.

github-actions · 2024-11-18T15:07:29Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-18T15:33:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/52392/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/52392/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/52392/NewExpensify.dmg	https://52392.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

feat: edge-to-edge mode on Android

6f13505

chrispader mentioned this pull request Nov 12, 2024

Migrate E/App to use PlatformStackNavigation #49937

Open

50 tasks

kirillzyusko added 2 commits November 12, 2024 16:40

fix: proper kav implementation for remaining platforms

70cfe6f

fix: eslint

c6cb0b3

shawnborton added the Ready To Build label Nov 12, 2024

fix: prettier

4cb3e3e

This comment has been minimized.

Sign in to view

mountiny assigned kirillzyusko Nov 12, 2024

mountiny requested review from Julesssss, mountiny and c3024 November 12, 2024 17:48

kirillzyusko added 2 commits November 13, 2024 14:00

fix: navigationBarTranslucent property for Modal

372d05a

fix: small bottom insets on Android

7f4dfad

kirillzyusko added 5 commits November 14, 2024 12:33

fix: do not use contrast enforcement for nav bar

5704b07

fix: splash screen jump on Android

862fffe

fix: nav bar manual theme management

b50083e

chore: rephrase a comment to avoid double wording

af30e2f

fix: incorrect window metrics on Android

2100beb

kirillzyusko commented Nov 14, 2024

View reviewed changes

kirillzyusko added 2 commits November 14, 2024 13:10

fix: prettier

ec2a2e1

fix: apply padding correction when keyboard gets shown on Android

14037ea

c3024 suggested changes Nov 15, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/AuthScreens.tsx Outdated Show resolved Hide resolved

src/styles/theme/types.ts Outdated Show resolved Hide resolved

src/styles/utils/index.ts Outdated Show resolved Hide resolved

kirillzyusko added 3 commits November 15, 2024 12:53

fix: changes after review

a194a59

fix: removed unused import

cd63c66

fix: crash on web

e718209

kirillzyusko mentioned this pull request Nov 15, 2024

fix: navigation bar color management #51956

Closed

47 tasks

fix: keyboard-avoiding-view in semi opened state

842ac00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: edge-to-edge mode on Android #52392

feat: edge-to-edge mode on Android #52392

kirillzyusko commented Nov 12, 2024 •

edited by mountiny

Loading

kirillzyusko commented Nov 12, 2024

shawnborton commented Nov 12, 2024

kirillzyusko commented Nov 12, 2024

shawnborton commented Nov 12, 2024

This comment has been minimized.

shawnborton commented Nov 12, 2024

mountiny commented Nov 12, 2024

dubielzyk-expensify commented Nov 13, 2024

shawnborton commented Nov 13, 2024

kirillzyusko commented Nov 13, 2024

mountiny commented Nov 13, 2024

kirillzyusko commented Nov 13, 2024

kirillzyusko Nov 14, 2024

kirillzyusko commented Nov 14, 2024

shawnborton commented Nov 14, 2024

kirillzyusko commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

dubielzyk-expensify commented Nov 15, 2024

c3024 left a comment

c3024 commented Nov 15, 2024

kirillzyusko commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

kirillzyusko commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

kirillzyusko commented Nov 18, 2024

c3024 commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

feat: edge-to-edge mode on Android #52392

Are you sure you want to change the base?

feat: edge-to-edge mode on Android #52392

Conversation

kirillzyusko commented Nov 12, 2024 • edited by mountiny Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

kirillzyusko commented Nov 12, 2024

shawnborton commented Nov 12, 2024

kirillzyusko commented Nov 12, 2024

shawnborton commented Nov 12, 2024

This comment has been minimized.

shawnborton commented Nov 12, 2024

mountiny commented Nov 12, 2024

dubielzyk-expensify commented Nov 13, 2024

shawnborton commented Nov 13, 2024

kirillzyusko commented Nov 13, 2024

mountiny commented Nov 13, 2024

kirillzyusko commented Nov 13, 2024

kirillzyusko Nov 14, 2024

Choose a reason for hiding this comment

kirillzyusko commented Nov 14, 2024

shawnborton commented Nov 14, 2024

kirillzyusko commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

dubielzyk-expensify commented Nov 15, 2024

c3024 left a comment

Choose a reason for hiding this comment

c3024 commented Nov 15, 2024

kirillzyusko commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

kirillzyusko commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

kirillzyusko commented Nov 18, 2024

c3024 commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

kirillzyusko commented Nov 12, 2024 •

edited by mountiny

Loading