-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD on #37891] Migrate E/App to use PlatformStackNavigation
#49937
Open
chrispader
wants to merge
190
commits into
Expensify:main
Choose a base branch
from
margelo:@chrispader/use-platform-stack-navigation-in-app
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[HOLD on #37891] Migrate E/App to use PlatformStackNavigation
#49937
chrispader
wants to merge
190
commits into
Expensify:main
from
margelo:@chrispader/use-platform-stack-navigation-in-app
+4,126
−1,192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oard handling (appearance from the bottom, blinks on hide gesture)
…reen to be disabled (when settings screen becomes shown again)
melvin-bot
bot
requested review from
srikarparsi
and removed request for
a team
September 30, 2024 14:32
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
chrispader
changed the title
[WIP] Use
[WIP] Use Sep 30, 2024
PlatformStackNavigation
in E/App (introduce native-stack
navigation on native)PlatformStackNavigation
in E/App (introduce native-stack
navigation on mobile)
chrispader
changed the title
[WIP] Use
[WIP] Migrate E/App to use Sep 30, 2024
PlatformStackNavigation
in E/App (introduce native-stack
navigation on mobile)PlatformStackNavigation
48 tasks
chrispader
changed the title
[WIP] Migrate E/App to use
[HOLD on #37891] Migrate E/App to use Sep 30, 2024
PlatformStackNavigation
PlatformStackNavigation
chrispader
force-pushed
the
@chrispader/use-platform-stack-navigation-in-app
branch
from
September 30, 2024 16:30
3b921d3
to
5701c46
Compare
Re-assigning to @chiragsalian and @mountiny for review since it looks like they have more context. |
srikarparsi
requested review from
chiragsalian and
mountiny
and removed request for
srikarparsi
September 30, 2024 16:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mountiny @ishpaul777 @chiragsalian
Details
This PR migrates the App to use
PlatformStackNavigation
types and navigator components implemented in #37891HOLD on #37891 to be merged first
Fixed Issues
$ #37891
PROPOSAL: #37891 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop