-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Self-guided tours][V3] Add tour link to FAB #51136
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
3620918
add selftourviewed command
rushatgabhane 31ff69b
add util to get tour url
rushatgabhane 5283953
use util to get url
rushatgabhane 1f022b4
fix staging url
rushatgabhane c1081d0
add tour icon
rushatgabhane cd6558b
add tour icon
rushatgabhane 3882077
add lang
rushatgabhane 469c052
add onboarding selftourviewed selector
rushatgabhane 63af4e7
add tour to FAB
rushatgabhane 55abb25
don't hide create workspace
rushatgabhane ab9331e
merge
rushatgabhane 9979c52
replace tour with binoculars icon
rushatgabhane 18daf19
add circle icon style
rushatgabhane c830443
change fab icon style
rushatgabhane 053b628
default to false
rushatgabhane b370bc6
replace withOnyx -> useOnyx
rushatgabhane 5fe757c
Update src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPo…
rushatgabhane 09dfbc9
add fixed width and height to icon
rushatgabhane 2c561ae
add fixed width and height to icon
rushatgabhane 4fd9885
fix typo
rushatgabhane 958b8e2
Merge branch 'main' into tour-fab
rushatgabhane 706a9dc
Merge branch 'Expensify:main' into tour-fab
rushatgabhane 069ec5b
Update src/libs/onboardingSelectors.ts
rushatgabhane 1c71ee6
move command
rushatgabhane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import type {ValueOf} from 'type-fest'; | ||
import CONST from '@src/CONST'; | ||
import type {OnboardingPurposeType} from '@src/CONST'; | ||
|
||
function getNavatticURL(environment: ValueOf<typeof CONST.ENVIRONMENT>, introSelected?: OnboardingPurposeType) { | ||
const adminTourURL = environment === CONST.ENVIRONMENT.PRODUCTION ? CONST.NAVATTIC.ADMIN_TOUR_PRODUCTION : CONST.NAVATTIC.ADMIN_TOUR_STAGING; | ||
const employeeTourURL = environment === CONST.ENVIRONMENT.PRODUCTION ? CONST.NAVATTIC.EMPLOYEE_TOUR_PRODUCTION : CONST.NAVATTIC.EMPLOYEE_TOUR_STAGING; | ||
return introSelected === CONST.SELECTABLE_ONBOARDING_CHOICES.MANAGE_TEAM ? adminTourURL : employeeTourURL; | ||
} | ||
|
||
export { | ||
// eslint-disable-next-line import/prefer-default-export | ||
getNavatticURL, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -35,4 +35,19 @@ function hasCompletedHybridAppOnboardingFlowSelector(tryNewDotData: OnyxValue<ty | |||||
return completedHybridAppOnboarding; | ||||||
} | ||||||
|
||||||
export {hasCompletedGuidedSetupFlowSelector, hasCompletedHybridAppOnboardingFlowSelector}; | ||||||
/** | ||||||
* Selector to get the value of selfTourViewed from the Onyx store | ||||||
* | ||||||
* `undefined` means the value is not loaded yet | ||||||
* `true` means the user has completed the NewDot onboarding flow | ||||||
* `false` means the user has not completed the NewDot onboarding flow | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
*/ | ||||||
function hasSeenTourSelector(onboarding: OnyxValue<typeof ONYXKEYS.NVP_ONBOARDING>): boolean | undefined { | ||||||
if (Array.isArray(onboarding)) { | ||||||
return false; | ||||||
} | ||||||
|
||||||
return onboarding?.selfTourViewed; | ||||||
} | ||||||
|
||||||
export {hasCompletedGuidedSetupFlowSelector, hasCompletedHybridAppOnboardingFlowSelector, hasSeenTourSelector}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.