[Self-guided tours][V3] Add tour link to FAB #51136

rushatgabhane · 2024-10-20T15:02:35Z

Details

Fixed Issues

$ #50926
PROPOSAL: N.A.

Tests

Admin

Create a new account
For onboarding purpose, choose "manage my team's expenses"
Verify that FAB menu has tour link and it opens admin tour.
Verify that you don't see tour link anymore in FAB menu.

Other onboarding purpose

Create a new account
For onboarding purpose, choose anything other than "manage my team's expenses"
Verify that you see New workspace button in FAB.
Verify that FAB menu has tour link and it opens employee tour.
Verify that you don't see tour link anymore in FAB menu.

Old accounts that have not completed onboarding ever.

If a user has never completed onboarding, then they won't see the tour link in FAB.
They should see in search page tho.

Old accounts that have completed onboarding should be able to see tour link.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-10-28.at.06.38.36.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-26.at.09.21.06.mov

Hovered

Without hover

MacOS: Desktop

melvin-bot · 2024-10-20T15:02:40Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dubielzyk-expensify · 2024-10-21T03:23:22Z

Now that we've updated the option rows icon colors, I wonder if we should tone back the Take a tour option row and remove the green. Maybe something like this?

Keen to get @Expensify/design thoughts before we charge ahead though.

shawnborton · 2024-10-21T06:40:56Z

I like that, this way it also won't compete with the green icon we use for creating a workspace from the global create menu right?

dubielzyk-expensify · 2024-10-21T07:48:48Z

Yeah, though there's a question of whether we should use the same treatment for that too? Actually. Let's just quickly take this to Slack before posting the final mocks here.

rushatgabhane · 2024-10-26T03:47:55Z

PR ready with udpated styles from slack

Hovered

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

dubielzyk-expensify · 2024-10-27T22:12:39Z

Looks great from a visual perspective 👍

c3024 · 2024-10-28T06:53:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

v3Android.mp4

Android: mWeb Chrome

v3AndroidmWeb.mp4

iOS: Native

v3iOS.mp4

iOS: mWeb Safari

v3iOSmWeb.mp4

MacOS: Chrome / Safari

v3Chrome.mp4

MacOS: Desktop

v3Desktop.mp4

c3024

LGTM!

shawnborton · 2024-10-28T08:30:22Z

Just to confirm - does the tour open up in a new tab/new window? I think so, but just want to double check.

rushatgabhane · 2024-10-28T08:33:26Z

New Tab

shawnborton · 2024-10-28T08:34:10Z

Sweet thanks for confirming!

shawnborton · 2024-10-28T08:34:46Z

Design-wise this looks good to me 👍

mountiny

This is mostly same as the v2 review here #51153 (review)

src/libs/onboardingSelectors.ts

rushatgabhane · 2024-11-04T18:54:22Z

@mountiny changes done. we should merge this PR first because v2 relies on it

mountiny

I think we can go with this one now!

mountiny · 2024-11-04T19:06:28Z

src/libs/onboardingSelectors.ts

+ * Selector to get the value of selfTourViewed from the Onyx store
+ *
+ * `undefined` means the value is not loaded yet
+ * `true` means the user has completed the NewDot onboarding flow


Suggested change

* `true` means the user has completed the NewDot onboarding flow

* `true` means the user has seen the navattic tour already

mountiny · 2024-11-04T19:06:43Z

src/libs/onboardingSelectors.ts

+ *
+ * `undefined` means the value is not loaded yet
+ * `true` means the user has completed the NewDot onboarding flow
+ * `false` means the user has not completed the NewDot onboarding flow


Suggested change

* `false` means the user has not completed the NewDot onboarding flow

* `false` means the user has not seen the navattic tour yet

OSBotify · 2024-11-04T19:21:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-06T00:36:37Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

MonilBhavsar · 2024-11-06T09:18:03Z

#52095 looks like a regression coming from this PR. Would be great if anyone can please take a look @rushatgabhane @c3024

ishpaul777 · 2024-11-06T21:51:28Z

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx

-export default withOnyx<FloatingActionButtonAndPopoverProps & RefAttributes<FloatingActionButtonAndPopoverRef>, FloatingActionButtonAndPopoverOnyxProps>({
-    allPolicies: {
-        key: ONYXKEYS.COLLECTION.POLICY,
-        selector: policySelector,
-    },
-    isLoading: {
-        key: ONYXKEYS.IS_LOADING_APP,
-    },
-    quickAction: {
-        key: ONYXKEYS.NVP_QUICK_ACTION_GLOBAL_CREATE,
-    },
-    quickActionReport: {
-        key: ({quickAction}) => `${ONYXKEYS.COLLECTION.REPORT}${quickAction?.chatReportID}`,
-    },
-    quickActionPolicy: {
-        key: ({quickActionReport}) => `${ONYXKEYS.COLLECTION.POLICY}${quickActionReport?.policyID}`,
-    },
-    personalDetails: {
-        key: ONYXKEYS.PERSONAL_DETAILS_LIST,
-    },
-    session: {
-        key: ONYXKEYS.SESSION,
-    },
-    hasSeenTrackTraining: {
-        key: ONYXKEYS.NVP_HAS_SEEN_TRACK_TRAINING,
-    },


I have started experiencing this #51242 again and i beleive withOnyx -> useOnyx migration in this PR caused it

cc @rushatgabhane @c3024

github-actions · 2024-11-07T12:41:39Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.58-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

rushatgabhane added 9 commits October 20, 2024 19:16

add selftourviewed command

3620918

add util to get tour url

31ff69b

use util to get url

5283953

fix staging url

1f022b4

add tour icon

c1081d0

add tour icon

cd6558b

add lang

3882077

add onboarding selftourviewed selector

469c052

add tour to FAB

63af4e7

rushatgabhane requested review from a team as code owners October 20, 2024 15:02

melvin-bot bot requested review from c3024 and removed request for a team October 20, 2024 15:02

rushatgabhane marked this pull request as draft October 20, 2024 15:03

rushatgabhane changed the title ~~[Self-guided tours][V3] Add tour link to FAB~~ [Pending on design doc][Self-guided tours][V3] Add tour link to FAB Oct 20, 2024

rushatgabhane changed the title ~~[Pending on design doc][Self-guided tours][V3] Add tour link to FAB~~ [Self-guided tours][V3] Add tour link to FAB Oct 26, 2024

rushatgabhane added 6 commits October 26, 2024 08:21

don't hide create workspace

55abb25

merge

ab9331e

replace tour with binoculars icon

9979c52

add circle icon style

18daf19

change fab icon style

c830443

default to false

053b628

rushatgabhane marked this pull request as ready for review October 26, 2024 03:47

replace withOnyx -> useOnyx

b370bc6

c3024 suggested changes Oct 26, 2024

View reviewed changes

src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.tsx Outdated Show resolved Hide resolved

rushatgabhane requested a review from c3024 October 26, 2024 14:36

rushatgabhane mentioned this pull request Oct 28, 2024

[Self-guided tours][V2] Add tour links to onboarding tasks #51153

Merged

50 tasks

c3024 approved these changes Oct 28, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny October 28, 2024 06:55

mountiny assigned rushatgabhane Oct 28, 2024

rushatgabhane added 2 commits October 29, 2024 20:08

Merge branch 'main' into tour-fab

958b8e2

Merge branch 'Expensify:main' into tour-fab

706a9dc

mountiny reviewed Nov 4, 2024

View reviewed changes

rushatgabhane commented Nov 4, 2024

View reviewed changes

src/libs/onboardingSelectors.ts Outdated Show resolved Hide resolved

rushatgabhane added 2 commits November 5, 2024 00:22

Update src/libs/onboardingSelectors.ts

069ec5b

move command

1c71ee6

rushatgabhane requested a review from mountiny November 4, 2024 18:53

mountiny approved these changes Nov 4, 2024

View reviewed changes

mountiny merged commit 09032ea into Expensify:main Nov 4, 2024
17 checks passed

github-actions bot mentioned this pull request Nov 5, 2024

Deploy Checklist: New Expensify 2024-11-05 #52084

Closed

71 tasks

NJ-2020 mentioned this pull request Nov 6, 2024

Public room - Tour link appears for anonymous user in public room #52115

Closed

8 tasks

ishpaul777 reviewed Nov 6, 2024

View reviewed changes

ishpaul777 mentioned this pull request Nov 6, 2024

[HOLD for payment 2024-11-20] [$250] FAB - Track expense option is not present in FAB for Expensifail account #51242

Open

8 tasks

melvin-bot bot mentioned this pull request Nov 7, 2024

[HOLD for payment 2024-11-14] [HOLD for payment 2024-10-29] Self-guided tours for onboarding (v1, 2, and 3) #50926

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Self-guided tours][V3] Add tour link to FAB #51136

[Self-guided tours][V3] Add tour link to FAB #51136

rushatgabhane commented Oct 20, 2024 •

edited

Loading

melvin-bot bot commented Oct 20, 2024

dubielzyk-expensify commented Oct 21, 2024 •

edited

Loading

shawnborton commented Oct 21, 2024

dubielzyk-expensify commented Oct 21, 2024

rushatgabhane commented Oct 26, 2024 •

edited

Loading

dubielzyk-expensify commented Oct 27, 2024

c3024 commented Oct 28, 2024 •

edited

Loading

c3024 left a comment

shawnborton commented Oct 28, 2024

rushatgabhane commented Oct 28, 2024

shawnborton commented Oct 28, 2024

shawnborton commented Oct 28, 2024

mountiny left a comment

rushatgabhane commented Nov 4, 2024

mountiny left a comment

mountiny Nov 4, 2024

mountiny Nov 4, 2024

OSBotify commented Nov 4, 2024

github-actions bot commented Nov 6, 2024

MonilBhavsar commented Nov 6, 2024

ishpaul777 Nov 6, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024

	* `true` means the user has completed the NewDot onboarding flow
	* `true` means the user has seen the navattic tour already

	* `false` means the user has not completed the NewDot onboarding flow
	* `false` means the user has not seen the navattic tour yet

[Self-guided tours][V3] Add tour link to FAB #51136

[Self-guided tours][V3] Add tour link to FAB #51136

Conversation

rushatgabhane commented Oct 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Admin

Other onboarding purpose

Old accounts that have not completed onboarding ever.

Old accounts that have completed onboarding should be able to see tour link.

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Hovered

Without hover

melvin-bot bot commented Oct 20, 2024

dubielzyk-expensify commented Oct 21, 2024 • edited Loading

shawnborton commented Oct 21, 2024

dubielzyk-expensify commented Oct 21, 2024

rushatgabhane commented Oct 26, 2024 • edited Loading

Hovered

dubielzyk-expensify commented Oct 27, 2024

c3024 commented Oct 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

shawnborton commented Oct 28, 2024

rushatgabhane commented Oct 28, 2024

shawnborton commented Oct 28, 2024

shawnborton commented Oct 28, 2024

mountiny left a comment

Choose a reason for hiding this comment

rushatgabhane commented Nov 4, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny Nov 4, 2024

Choose a reason for hiding this comment

mountiny Nov 4, 2024

Choose a reason for hiding this comment

OSBotify commented Nov 4, 2024

github-actions bot commented Nov 6, 2024

MonilBhavsar commented Nov 6, 2024

ishpaul777 Nov 6, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Nov 7, 2024

rushatgabhane commented Oct 20, 2024 •

edited

Loading

dubielzyk-expensify commented Oct 21, 2024 •

edited

Loading

rushatgabhane commented Oct 26, 2024 •

edited

Loading

c3024 commented Oct 28, 2024 •

edited

Loading

ishpaul777 Nov 6, 2024 •

edited

Loading