Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2024-09-05 #48664

Closed
69 tasks done
github-actions bot opened this issue Sep 5, 2024 · 15 comments
Closed
69 tasks done

Deploy Checklist: New Expensify 2024-09-05 #48664

github-actions bot opened this issue Sep 5, 2024 · 15 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Reviewing Has a PR in review StagingDeployCash Weekly KSv2

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Release Version: 9.0.30-19
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@blimpich
Copy link
Contributor

blimpich commented Sep 5, 2024

checking off #48514, QA-ed here

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 5, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Sep 5, 2024

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.30-3 🚀

@kavimuru
Copy link

kavimuru commented Sep 6, 2024

Regression is at 85%
Unchecked PRs:
#46667 - Pending validation on iOS
#48001 - Pending validation on iOS
#48014 - Pending validation on mWeb
#48144 - Pending validation on android and iOS
#48227 - Pending validation on mWeb and Desktop
#48381 - Failing with #48675
#48391 - failing with #48676
#48411 - Pending validation
#48414 - Pending validation in iOS
#48086 pending validation in all the platforms
#48520 pending validation in iOS
#48593 pending validation in android and iOS

@Julesssss
Copy link
Contributor

Deploy blocker #48682 was fixed by this PR and CP

@kavimuru
Copy link

kavimuru commented Sep 6, 2024

Regression is left few untested steps
unchecked PRs:
#48001 - failing with #48686
#48014 - failing with #48701 repro in production, checking it off
#48144 - Deeplink is not working for signed out user in iOS and android other platforms are pass
#48227 - Pending validation on mWeb and Desktop
#48381 - Failing with #48675
#48391 - failing with #48676
#48708 - CP is being validated

#48689 - CP is being validated

@lakchote
Copy link
Contributor

lakchote commented Sep 6, 2024

Checked off #48676 and #48690 (more details)

@youssef-lr
Copy link
Contributor

Checking off #48686, a fix was CP'ed

@kavimuru
Copy link

kavimuru commented Sep 8, 2024

Regression is completed.
#48001 - failing with https://github.com/Expensify/App/issues/48686u
#48014 - failing with #48701 repro in production checking it off
#48144 - Deeplink is not working for signed out user in iOS and android other platforms are pass
#48381 - Failing with #48675
#48391 - failing with #48676
#48698 pending validation CP
#48723 pending validation CP
#48739 pending validation CP

@mountiny
Copy link
Contributor

mountiny commented Sep 9, 2024

#48628 worked fine

@luacmartins luacmartins self-assigned this Sep 9, 2024
@luacmartins luacmartins added the Daily KSv2 label Sep 9, 2024
@luacmartins
Copy link
Contributor

Validated #48001 after this CP and it's a pass

@luacmartins
Copy link
Contributor

Validated #48144 on iOS and android. It's a pass.

@luacmartins
Copy link
Contributor

Validated #48381 after this CP. It's a pass.

@luacmartins
Copy link
Contributor

Validated #48391 on android after this CP. It's a pass.

@luacmartins
Copy link
Contributor

All checks are nominal. Shipping it.

@luacmartins
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Reviewing Has a PR in review StagingDeployCash Weekly KSv2
Projects
None yet
Development

No branches or pull requests