[HOLD for payment 2024-09-16][$250] [Search v2.1] Remove isCustomQuery from URL

[luacmartins]

Problem

Coming from here, we decided to remove the isCustomQuery param from the URL.

Solution

Remove the param

cc @Kicu

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c7e181cb4efa9de7
• Upwork Job ID: 1830622690254016755
• Last Price Increase: 2024-09-02

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[Kicu]

I can take this, please assign me.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c7e181cb4efa9de7

[melvin-bot]

Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

[Kicu]

PR ready - I think it was a good decision because the code ended up being simpler, and we now have only 1 query param in Search screens - q and that sounds like a win to me 👍

#48414

[luacmartins]

PR was deployed to prod 2 days ago on this checklist

[sakluger]

Commenting for melvin since I have the assignment star.

[sakluger]

Monday payment

[ikevin127]

Offer accepted, thank you!

[sakluger]

Posting the offer so I can find it again on Monday 😄

https://www.upwork.com/nx/wm/offer/103953094

@ikevin127 do we need any regression tests for this one? I feel like we don't but curious for your take.

[ikevin127]

@sakluger I've asked (ref1, ref2, ref3) whether regression tests are needed on Search v2.1 related issues and was told (ref1, ref2, ref3) that regression tests will be added later as part of the project wrap up.

[sakluger]

Sounds good, thanks for confirming @ikevin127.

[sakluger]

The contract is paid, thanks everyone!