[HOLD for payment 2024-09-16][$250] mWeb - Chat - In contacts a random guest user is displayed after login via public room link

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.22
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to this link as signed out user https://staging.new.expensify.com/r/7075912447943023
2. Tap sign in
3. Enter credentials and log in
4. Navigate to LHN
5. Tap fab -- start chat
6. In contacts, note a guest user is added.

Expected Result:

In contacts, a random guest user must not be displayed after login via public room link

Actual Result:

In contacts, a random guest user is displayed after login via public room link

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6578301_1724253847611.screenrecorder-2024-08-21-15-17-35-544_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0148f0358fba85f9ac
• Upwork Job ID: 1828135607297326184
• Last Price Increase: 2024-08-26
• Automatic offers:
• jjcoffee | Reviewer | 103703199
• dominictb | Contributor | 103703202

Issue Owner

Current Issue Owner: @jjcoffee

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dominictb]

Edited by proposal-police: This proposal was edited at 2023-10-07T14:32:22Z.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In contacts, a random guest user is displayed after login via public room link

What is the root cause of that problem?

When opening a public room as an anonymous user, the session data is:

accountID: A,
email: [email protected]

and we create a personal detail for it:

accountID: A,
displayName: "Guest",
lastName: "Guest"

and after signing, we do not clear these data, so these data appear in contact list.

What changes do you think we should make in order to solve the problem?

• We should create a function to cleanup the anon personal detail:

function removeAnonFromPersonalDetails() {
    const anonAccountIDs = Object.values(personalDetails).filter((detail) => detail?.login?.includes('@expensify.anon'));
    const data = anonAccountIDs.reduce((res, detail) => ({...res, [detail.accountID]: null}), {});
    Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, data);
}

and call it in:

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Line 124 in f12c1ff

// This means sign in in RHP was successful, so we can subscribe to user events

What alternative solutions did you explore? (Optional)

• Solution 1:

Can use useEffect:

    const isAnonymousUser = session?.authTokenType === CONST.AUTH_TOKEN_TYPES.ANONYMOUS;
    const prevIsAnonymousUser = usePrevious(isAnonymousUser);
    useEffect(() => {
        if (prevIsAnonymousUser && !isAnonymousUser) {
            removeAnonFromPersonalDetails();
        }
    }, [prevIsAnonymousUser, isAnonymousUser]);

• Solution 2:

Can cleanup the anon personal details when the sign in API is called successfully, such as in:

App/src/libs/actions/Session/index.ts

Line 520 in f12c1ff

const successData: OnyxUpdate[] = [

and

App/src/libs/actions/Session/index.ts

Line 588 in f12c1ff

const successData: OnyxUpdate[] = [

[dominictb]

Proposal Updated

[CortneyOfstad]

I am confused by the steps, as it specifically mentions In contacts, note a guest user is added.

The contact was not added to the chat, but rather a suggestion. And this is by design.

@lanitochka17 does the tester recognize that email in any capacity in regards to Expensify or testing within Expensify?

[dominictb]

@CortneyOfstad
If we do not sign in and then visit the public room, a random personal detail data is assigned to us. That data is something like:

accountID: A,
displayName: "Guest",
lastName: "Guest",
login: [email protected],

Then when signing in, the above random user data is not cleared, so it is displayed in the contact list.

[CortneyOfstad]

Thank you @dominictb for the clarification!

I am having trouble recreating this, so I am going to have this retest by QA 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0148f0358fba85f9ac

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot]

@CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jjcoffee]

@dominictb's proposal LGTM! I think cleaning up on the API success callback seems the neatest way to do this as we can then pass the accountID to clear from the session data. Happy to listen to arguments otherwise if I've missed anything!

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Yeah updating it in the success data makes sense to me, then we already know which account ID to remove.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[CortneyOfstad]

PR is still being reviewed!

[bfitzexpensify]

@dominictb @jjcoffee can you please take a look at #48715 to see if it is related to your changes? It was found while executing #48144

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[VictoriaExpensify]

Bumping Ben's message above - @jjcoffee I think you were looking into this:

@dominictb @jjcoffee can you please take a look at #48715 to see if it is related to your changes? It was found while executing #48144

It looks like these are probably related issues

[jjcoffee]

I can't repro after reverting the changes from the PR, so I don't think it's related.

[dominictb]

I can reproduce that bug in prod, so I think it is not related to PR, because it is not deployed to prod.

cc @bfitzexpensify

[jjcoffee]

Looks like the automation failed again! This hit production 2024-09-09, so this should be held for payment 2024-09-16. cc @CortneyOfstad

[CortneyOfstad]

Thanks @jjcoffee!

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[CortneyOfstad]

Payment Summary

@jjcoffee — paid $250 via Upwork
@dominictb — paid $250 via Upwork