[HOLD for payment 2023-05-16] [HOLD for payment 2023-05-09] [$1000] Add button is not grayed out on 'New contact method' page when there is no entry in email field

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on 'Avatar'
2. Click on 'Profile' link
3. Click on 'Contact method' link
4. Click on 'New contact method' button

Expected Result:

Add button should be grayed out

Actual Result:

Add button is not grayed out even though there is no entry in email field
NOTE: There is similar behavior on some more places: Split bill, Request money, Send money.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8-4
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-04-28.12.39.32.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682675145624049?thread_ts=1682674162.053429&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016facff92aad4650e
• Upwork Job ID: 1653137265055600640
• Last Price Increase: 2023-05-01

[MelvinBot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[puneetlath]

Looking into it.

[Natnael-Guchima]

Hello @puneetlath. This issue is also observable on contact methods section, split bill, request money, and send money. I have tried to collect all impacted section I have found in this slack thread. Please, take a look at it.

[situchan]

I think the regression came from #17404 where touched OpacityView

[robertKozik]

The problem is that opacity, in this case, is being controlled by both passed style and animated opacity. On mount animated opacity overrides the one passed with styles and goes back to 1. Potential fix: all styling will be applied to the view, which is a child of OpacityView, so opacity won't be crashing between each other.

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[puneetlath]

This has been fixed on staging.

[Natnael-Guchima]

Yes, it was fixed on staging @puneetlath . This issue was a deploy blocker introduced by this PR. And it was fixed with this PR. Shouldn't this be eligible for reporting bonus since the fix was initiated by the bug report?
Thanks.

[Natnael-Guchima]

Yes, it was fixed on staging @puneetlath . This issue was a deploy blocker introduced by this PR. And it was fixed with this PR. Shouldn't this be eligible for reporting bonus since the fix was initiated by the bug report? Thanks.

The offending PR and the fix are in the same release here(#18132)

[puneetlath]

Right you are!

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[puneetlath]

Can you apply to the Upwork job @Natnael-Guchima: https://www.upwork.com/jobs/~016facff92aad4650e

[Natnael-Guchima]

Can you apply to the Upwork job @Natnael-Guchima: https://www.upwork.com/jobs/~016facff92aad4650e

Done! Thanks @puneetlath .

[marcaaron]

This looks fixed on staging so removing the blocker and checking it off.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.8-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix applying styling when it want to apply opacity on OpacityView #18153

If no regressions arise, payment will be issued on 2023-05-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @Natnael-Guchima
• Contributor that fixed the issue n/a
• Contributor+ that helped on the issue and/or PR @aimane-chnaif

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@puneetlath] The PR that introduced the bug has been identified. Link to the PR: [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback #17404
• [@puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback #17404 (comment)
• [@puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback #17404 (comment)
• [@puneetlath] Determine if we should create a regression test for this bug. n/a was caught on staging during regression testing
• [@puneetlath] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath / @kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@kadiealexander the checklist is done and @Natnael-Guchima has been paid, so you just need to pay out @aimane-chnaif on may 9th.

[aimane-chnaif]

Note: @puneetlath hired me on upwork on May 1 and contract is open.

[kadiealexander]

Roger that, thanks Puneet and Aimane!

[puneetlath]

I went ahead and paid @aimane-chnaif. Closing this out.

[kadiealexander]

Sorry, the new date in the title threw me! Thanks Puneet!