-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-05-09] [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback; #16988
Comments
Triggered auto assignment to @mallenexpensify ( |
cc @robertKozik please comment on this so that I can assign it to you. |
@robertKozik Huh... This is 4 days overdue. Who can take care of this? |
I'm finishing implementing required components. |
@robertKozik Do you have a draft PR? |
Yes here: #17404. I'll link it asap. |
📣 @robertKozik! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Format:
|
@robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick! |
PR #17404 is ready and is waiting for review |
I have reviewed the PR a few times and just approved it. I've asked for a couple people to help review it just to get some extra eyes on it, because it's quite important. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.8-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-05-09. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
no payments due here, so I'm going to close this. |
HOLD on #16987
Design doc section
High level description
Create three new components:
GenericPressable
PressableWithFeedback
PressableWithoutFeedback
according to the specification of the doc, to replace all current
Touchable
andPressable
components.The text was updated successfully, but these errors were encountered: