Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-09] [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback; #16988

Closed
roryabraham opened this issue Apr 6, 2023 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

HOLD on #16987

Design doc section

High level description

Create three new components:

  • GenericPressable
  • PressableWithFeedback
  • PressableWithoutFeedback

according to the specification of the doc, to replace all current Touchable and Pressable components.

@roryabraham roryabraham added Weekly KSv2 NewFeature Something to build that is a new item. labels Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot
Copy link

@roryabraham
Copy link
Contributor Author

cc @robertKozik please comment on this so that I can assign it to you.

@roryabraham roryabraham changed the title [HOLD][Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback; [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback; Apr 10, 2023
@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables Apr 10, 2023
@roryabraham roryabraham added Daily KSv2 and removed Weekly KSv2 labels Apr 12, 2023
@MelvinBot
Copy link

@robertKozik Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Apr 17, 2023
@robertKozik
Copy link
Contributor

I'm finishing implementing required components.

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2023
@roryabraham
Copy link
Contributor Author

@robertKozik Do you have a draft PR?

@robertKozik
Copy link
Contributor

Yes here: #17404. I'll link it asap.

@MelvinBot
Copy link

📣 @robertKozik! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Screen Shot 2022-11-16 at 4 42 54 PM

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@MelvinBot
Copy link

@robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick!

@robertKozik
Copy link
Contributor

PR #17404 is ready and is waiting for review

@roryabraham
Copy link
Contributor Author

I have reviewed the PR a few times and just approved it. I've asked for a couple people to help review it just to get some extra eyes on it, because it's quite important.

@roryabraham roryabraham moved this from In Progress to Done in Accessible Pressables Apr 27, 2023
@MelvinBot
Copy link

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@MelvinBot
Copy link

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 2, 2023
@melvin-bot melvin-bot bot changed the title [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback; [HOLD for payment 2023-05-09] [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback; May 2, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 2, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.8-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 8, 2023
@roryabraham
Copy link
Contributor Author

no payments due here, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants