Deploy Checklist: New Expensify 2023-04-28

[OSBotify]

Release Version: 1.3.8-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Optimistically create policy expense chats for new members of workspaces #16764
• Resize and automatically hide attachment carousel arrows #17269
• Use PickerAvoidingView from react-native-picker-select #17279
• [Accessible Pressable] Create GenericPressable, PressableWithFeedback, PressableWithoutFeedback #17404
• [ExpensifyHelp] Dynamically create the routes file for docs #17489
• LegalNamePage function component refactor #17542
• [PhoneNumber Verification] Display only valid numbers in user search. #17578
• fix: fix ios freezing screen issue #17881
• Fix: Use label instead of placeholder for option selector #17991
• Fix space between the tooltip and the arrow if the component is positioned on the extreme left or right #18012
• fix: always show the default contact method at the top of the "Contact methods" list #18029
• fix: double pressing CTR+K removes focus #18039
• upgrade onfido-sdk-ui version #18050
• [No-QA] Create referral-program help page on ExpensifyHelp #18070
• [ExpensifyHelp] fix: add file extension for an article #18097
• Revert "[PhoneNumber Verification] Display only valid numbers in user search." #18100
• [Accessible Pressable] fix checking current field on undefined ref in BaseGenericPressable #18106
• Allow navigating to public announce rooms as the initial report after signing in/signing up #18114
• Fix applying styling when it want to apply opacity on OpacityView #18153
• fix: re-add placeholder text inside base option selector #18155
• [NoQA] Add falsey checks and _.compact() to places where we access SMS logins from personal details #18159
• [NoQA] Remove unnecessary participants filtering #18173

Deploy Blockers:

• Remove button is not grayed out on 'Manage members' page when there is no selection #18145
• [HOLD for payment 2023-05-16] [HOLD for payment 2023-05-09] [$1000] Add button is not grayed out on 'New contact method' page when there is no entry in email field #18146
• [$1000] mWeb - New Chat/New Group/ Request/ Send/Split - New email field is fulfilled with delay when typing #18154
• Settings - Buttons are not grey out if user switches to offline at another place #18169
• Delete comment tooltip overlapping with scrollbar #18231

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.8-4 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.8-5 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.8-5 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.8-6 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.8-7 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.8-6 has been deployed to staging 🎉

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.8-7 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.8-8 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.8-8 has been deployed to staging 🎉

[mvtglobally]

Regression is completed.

PR #17269 is failing #18151
PR #17578 failing as it has been reverted #18100. Ok to checkoff?

[MelvinBot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[marcaaron]

Checking off #18169 as per #18169 (comment)

[marcaaron]

Checking off #18145 as per #18145 (comment)

[marcaaron]

#18146 also looks fixed #18146 (comment)

[marcaaron]

Tested #18154 now and checking it off because there's no clear difference between staging and production. Both are pretty bad so the issue needs to be looked into with some priority.

[marcaaron]

Checking off #18173 as per https://expensify.slack.com/archives/C9YU7BX5M/p1682992361381279?thread_ts=1682985566.165469&cid=C9YU7BX5M

[marcaaron]