Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Delete field Share::evals, extract data from eval_proofs instead #674

Merged
merged 11 commits into from
Sep 4, 2024
Merged

fix: Delete field Share::evals, extract data from eval_proofs instead #674

merged 11 commits into from
Sep 4, 2024

Commits on Sep 3, 2024

  1. add comments

    @ggutoski
    ggutoski committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    189ac0c View commit details
    Browse the repository at this point in the history

  2. new method Share::evals() replicates struct field Share::evals

    @ggutoski
    ggutoski committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    78aa38a View commit details
    Browse the repository at this point in the history

  3. delete field Shares::evals

    @ggutoski
    ggutoski committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    52816db View commit details
    Browse the repository at this point in the history

  4. comment out tests that are broken by deleting Share::evals

    @ggutoski
    ggutoski committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    2d9c755 View commit details
    Browse the repository at this point in the history

  5. Share::evals() use extract_leaf

    @ggutoski
    ggutoski committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f5ad195 View commit details
    Browse the repository at this point in the history

  6. new test-only method Share::extract_leaf_mut, use it to restore tests

    @ggutoski
    ggutoski committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    3cb124b View commit details
    Browse the repository at this point in the history

  7. oops: use evals instead of share.evals()?

    @ggutoski
    ggutoski committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6179d54 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. use MerkleProof::elem instead of doing it myself

    @ggutoski
    ggutoski committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6ba26c4 View commit details
    Browse the repository at this point in the history

  2. move Share::extract_leaf_mut to test.rs, delete Share::extract_leaf

    @ggutoski
    ggutoski committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    116c0eb View commit details
    Browse the repository at this point in the history

  3. revise comment

    @ggutoski
    ggutoski committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f396171 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into gg/659-2

    @ggutoski
    ggutoski authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    32da2e9 View commit details
    Browse the repository at this point in the history