-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(2022 - 2025) Remove Index.tsx from Measures #2539
Merged
Merged
Changes from 49 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
a8126fd
test loading addch from template
ailZhou a1ff701
Merge branch 'master' into clean-measure-2021
ailZhou 600f699
Merge branch 'master' into clean-measure-2021
ailZhou 63a5cbc
Merge branch 'master' into clean-measure-2021
ailZhou 7d6f8d3
migrate child index data to data file
ailZhou 77f4875
remove index files
ailZhou fe50760
fix validation errors caused by import changes
ailZhou e8fffc6
prettier cleanup
ailZhou c9c36ff
clean up
ailZhou c2eefae
fixed imports thanks to Brendan
ailZhou 2ebf446
fix other import issues
ailZhou 39e1d91
moved ad and hh index data to the data file
ailZhou dbbbe75
validation fixes
ailZhou 07f4c4a
fix prettier issues
ailZhou f9b22a4
Update data.ts
ailZhou 1a61269
clean up
ailZhou 32b143b
remove junk
ailZhou ad6931c
fixing bugs and wrong linking
ailZhou 858258c
missed something in FVA-AD & CDF-HH
ailZhou 9e33e14
auto generated data for 2022
ailZhou b848534
validation updates
ailZhou 71867ef
fixes
ailZhou 330f680
added in missing files and updated imports
ailZhou 4ef9f8d
fixed mangled data
ailZhou 9779771
validation import fix
ailZhou 6d565d8
Update data.ts
ailZhou 1a06758
Merge branch 'master' into clean-measure-auto
ailZhou 9f3aa51
fix unit test
ailZhou dc9f5eb
remove comment import
ailZhou 3386d2d
data fixes in 2021
ailZhou 5ad1abc
missing data for 2022
ailZhou 8ac9e31
more template fix
ailZhou 39b5c01
processed 2023 files
ailZhou 2c64672
2023 measure template
ailZhou 49b621f
validation cleanup 2023
ailZhou 0212c7d
missing pieces fixes for 2025
ailZhou c90d96e
another missed update
ailZhou 5b96795
wrong type
ailZhou c31fef5
why did this go missing
ailZhou 9d2dd91
2024 measureTemplate
ailZhou 2f6ecab
2024 porting index to data files
ailZhou b0cb265
2024 validation import fixes
ailZhou b830504
fixed leftover errors
ailZhou 51dc21a
2025 index to data files
ailZhou 646f9a5
2025 validations
ailZhou fc33d82
fixes
ailZhou 1f0baf4
turn off measures that haven't been made yet
ailZhou 59b0eb3
adding unit test
ailZhou 71f8b29
fixing errors caused by my own laziness
ailZhou 302f518
fixes Ben caught
ailZhou 6679fd7
more Ben catches!
ailZhou 879458e
missing is hybrid
ailZhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,7 +4,7 @@ import { RouterWrappedComp } from "utils/testing"; | |
import { MeasureWrapper } from "./"; | ||
import { useApiMock } from "utils/testUtils/useApiMock"; | ||
import { useUser } from "hooks/authHooks"; | ||
import { AABAD } from "measures/2024/AABAD/index"; | ||
import { CPUAD } from "measures/2024/CPUAD/index"; | ||
|
||
jest.mock("hooks/authHooks"); | ||
const mockUseUser = useUser as jest.Mock; | ||
|
@@ -146,13 +146,13 @@ describe("test measure floating bar menu", () => { | |
<RouterWrappedComp> | ||
<MeasureWrapper | ||
measure={ | ||
<AABAD | ||
<CPUAD | ||
name={ | ||
"Avoidance of Antibiotic Treatment for Acute Bronchitis/Bronchiolitis: Age 18 And Older" | ||
} | ||
year={"2024"} | ||
measureId={"AAB-AD"} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will do the same as above for this one as well |
||
></AABAD> | ||
></CPUAD> | ||
} | ||
name="testing-active" | ||
year="2021" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,5 +16,6 @@ export const data: MeasureTemplateData = { | |
}, | ||
custom: { | ||
dataSrcRadio: true, | ||
removeLessThan30: true, | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,23 @@ | ||
import { DataDrivenTypes } from "shared/types"; | ||
import { AABRateCalculation } from "utils"; | ||
import { getCatQualLabels } from "../rateLabelText"; | ||
import { MeasureTemplateData } from "shared/types/MeasureTemplate"; | ||
|
||
export const { categories, qualifiers } = getCatQualLabels("AAB-AD"); | ||
|
||
export const data: DataDrivenTypes.PerformanceMeasure = { | ||
customPrompt: | ||
"Enter a number for the numerator and the denominator. The measure is reported as an inverted rate. The formula for the Rate = (1 - (Numerator/Denominator)) x 100", | ||
questionText: [ | ||
"The percentage of episodes for beneficiaries age 18 and older with a diagnosis of acute bronchitis/bronchiolitis that did not result in an antibiotic dispensing event.", | ||
], | ||
questionListItems: [], | ||
categories, | ||
qualifiers, | ||
export const data: MeasureTemplateData = { | ||
type: "HEDIS", | ||
coreset: "adult", | ||
performanceMeasure: { | ||
customPrompt: | ||
"Enter a number for the numerator and the denominator. The measure is reported as an inverted rate. The formula for the Rate = (1 - (Numerator/Denominator)) x 100", | ||
questionText: [ | ||
"The percentage of episodes for beneficiaries age 18 and older with a diagnosis of acute bronchitis/bronchiolitis that did not result in an antibiotic dispensing event.", | ||
], | ||
questionListItems: [], | ||
categories, | ||
qualifiers, | ||
}, | ||
custom: { | ||
rateCalc: AABRateCalculation, | ||
}, | ||
}; |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to match the name and measureId for CPUAD here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we probably should for consistency sake. i'll make the changes in a less chonky PR. thanks!