Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(2022 - 2025) Remove Index.tsx from Measures #2539

Merged
merged 52 commits into from
Jan 21, 2025
Merged
Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
a8126fd
test loading addch from template
ailZhou Dec 10, 2024
a1ff701
Merge branch 'master' into clean-measure-2021
ailZhou Dec 13, 2024
600f699
Merge branch 'master' into clean-measure-2021
ailZhou Dec 16, 2024
63a5cbc
Merge branch 'master' into clean-measure-2021
ailZhou Jan 7, 2025
7d6f8d3
migrate child index data to data file
ailZhou Jan 7, 2025
77f4875
remove index files
ailZhou Jan 7, 2025
fe50760
fix validation errors caused by import changes
ailZhou Jan 7, 2025
e8fffc6
prettier cleanup
ailZhou Jan 7, 2025
c9c36ff
clean up
ailZhou Jan 7, 2025
c2eefae
fixed imports thanks to Brendan
ailZhou Jan 8, 2025
2ebf446
fix other import issues
ailZhou Jan 8, 2025
39e1d91
moved ad and hh index data to the data file
ailZhou Jan 9, 2025
dbbbe75
validation fixes
ailZhou Jan 9, 2025
07f4c4a
fix prettier issues
ailZhou Jan 9, 2025
f9b22a4
Update data.ts
ailZhou Jan 9, 2025
1a61269
clean up
ailZhou Jan 10, 2025
32b143b
remove junk
ailZhou Jan 10, 2025
ad6931c
fixing bugs and wrong linking
ailZhou Jan 10, 2025
858258c
missed something in FVA-AD & CDF-HH
ailZhou Jan 10, 2025
9e33e14
auto generated data for 2022
ailZhou Jan 14, 2025
b848534
validation updates
ailZhou Jan 14, 2025
71867ef
fixes
ailZhou Jan 14, 2025
330f680
added in missing files and updated imports
ailZhou Jan 14, 2025
4ef9f8d
fixed mangled data
ailZhou Jan 14, 2025
9779771
validation import fix
ailZhou Jan 14, 2025
6d565d8
Update data.ts
ailZhou Jan 14, 2025
1a06758
Merge branch 'master' into clean-measure-auto
ailZhou Jan 15, 2025
9f3aa51
fix unit test
ailZhou Jan 15, 2025
dc9f5eb
remove comment import
ailZhou Jan 15, 2025
3386d2d
data fixes in 2021
ailZhou Jan 15, 2025
5ad1abc
missing data for 2022
ailZhou Jan 15, 2025
8ac9e31
more template fix
ailZhou Jan 15, 2025
39b5c01
processed 2023 files
ailZhou Jan 15, 2025
2c64672
2023 measure template
ailZhou Jan 15, 2025
49b621f
validation cleanup 2023
ailZhou Jan 15, 2025
0212c7d
missing pieces fixes for 2025
ailZhou Jan 15, 2025
c90d96e
another missed update
ailZhou Jan 15, 2025
5b96795
wrong type
ailZhou Jan 15, 2025
c31fef5
why did this go missing
ailZhou Jan 15, 2025
9d2dd91
2024 measureTemplate
ailZhou Jan 15, 2025
2f6ecab
2024 porting index to data files
ailZhou Jan 15, 2025
b0cb265
2024 validation import fixes
ailZhou Jan 15, 2025
b830504
fixed leftover errors
ailZhou Jan 15, 2025
51dc21a
2025 index to data files
ailZhou Jan 15, 2025
646f9a5
2025 validations
ailZhou Jan 15, 2025
fc33d82
fixes
ailZhou Jan 15, 2025
1f0baf4
turn off measures that haven't been made yet
ailZhou Jan 16, 2025
59b0eb3
adding unit test
ailZhou Jan 16, 2025
71f8b29
fixing errors caused by my own laziness
ailZhou Jan 16, 2025
302f518
fixes Ben caught
ailZhou Jan 21, 2025
6679fd7
more Ben catches!
ailZhou Jan 21, 2025
879458e
missing is hybrid
ailZhou Jan 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { RouterWrappedComp } from "utils/testing";
import { MeasureWrapper } from "./";
import { useApiMock } from "utils/testUtils/useApiMock";
import { useUser } from "hooks/authHooks";
import { AABAD } from "measures/2024/AABAD/index";
import { CPUAD } from "measures/2024/CPUAD/index";

jest.mock("hooks/authHooks");
const mockUseUser = useUser as jest.Mock;
Expand Down Expand Up @@ -146,13 +146,13 @@ describe("test measure floating bar menu", () => {
<RouterWrappedComp>
<MeasureWrapper
measure={
<AABAD
<CPUAD
name={
"Avoidance of Antibiotic Treatment for Acute Bronchitis/Bronchiolitis: Age 18 And Older"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to match the name and measureId for CPUAD here too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we probably should for consistency sake. i'll make the changes in a less chonky PR. thanks!

}
year={"2024"}
measureId={"AAB-AD"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be measureId={"CPU-AD"}

Copy link
Collaborator Author

@ailZhou ailZhou Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do the same as above for this one as well

></AABAD>
></CPUAD>
}
name="testing-active"
year="2021"
Expand Down
1 change: 0 additions & 1 deletion services/ui-src/src/measures/2021/CCPCH/data.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// import { DataDrivenTypes } from "shared/types";
import { getCatQualLabels } from "../rateLabelText";
import { MeasureTemplateData } from "shared/types/MeasureTemplate";

Expand Down
1 change: 1 addition & 0 deletions services/ui-src/src/measures/2021/FVAAD/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,6 @@ export const data: MeasureTemplateData = {
},
custom: {
dataSrcRadio: true,
removeLessThan30: true,
},
};
2 changes: 1 addition & 1 deletion services/ui-src/src/measures/2021/PQI15AD/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export const { categories, qualifiers } = getCatQualLabels("PQI15-AD");

export const data: MeasureTemplateData = {
type: "AHRQ",
coreset: "health",
coreset: "adult",
performanceMeasure: {
questionText: [
"Number of inpatient hospital admissions for asthma per 100,000 beneficiary months for beneficiaries ages 18 to 39.",
Expand Down
2 changes: 1 addition & 1 deletion services/ui-src/src/measures/2021/SSDAD/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const { categories, qualifiers } = getCatQualLabels("SSD-AD");

export const data: MeasureTemplateData = {
type: "HEDIS",
coreset: "health",
coreset: "adult",
performanceMeasure: {
questionText: [
"Percentage of beneficiaries ages 18 to 64 with schizophrenia, schizoaffective disorder, or bipolar disorder, who were dispensed an antipsychotic medication and had a diabetes screening test during the measurement year.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { Suspense } from "react";
import { MeasuresLoading } from "views";
import { measureDescriptions } from "measures/measureDescriptions";
import { renderWithHookForm } from "utils/testUtils/reactHookFormRenderer";
import { validationFunctions } from "./validation";
import { validationFunctions } from "./CCWAD/validation";
import {
mockValidateAndSetErrors,
clearMocks,
Expand Down
4 changes: 3 additions & 1 deletion services/ui-src/src/measures/2021/measureTemplate.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ export const measureTemplate = ({
reportingYear={year}
measureName={name}
measureAbbreviation={measureId}
removeLessThan30={custom?.removeLessThan30}
/>

{!isNotReportingData && (
Expand Down Expand Up @@ -76,6 +77,7 @@ export const measureTemplate = ({
showtextbox={custom?.showtextbox}
hybridMeasure={hybridMeasure}
rateReadOnly={custom?.rateReadOnly}
rateCalc={custom?.rateCalc}
/>
<CMQ.DeviationFromMeasureSpecificationCheckboxes
categories={performanceMeasure.categories}
Expand All @@ -92,7 +94,7 @@ export const measureTemplate = ({
}
/>
)}
<CMQ.CombinedRates />
<CMQ.CombinedRates coreset={coreset} />
{showOptionalMeasureStrat && (
<CMQ.OptionalMeasureStrat
coreset={coreset}
Expand Down
28 changes: 18 additions & 10 deletions services/ui-src/src/measures/2022/AABAD/data.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,23 @@
import { DataDrivenTypes } from "shared/types";
import { AABRateCalculation } from "utils";
import { getCatQualLabels } from "../rateLabelText";
import { MeasureTemplateData } from "shared/types/MeasureTemplate";

export const { categories, qualifiers } = getCatQualLabels("AAB-AD");

export const data: DataDrivenTypes.PerformanceMeasure = {
customPrompt:
"Enter a number for the numerator and the denominator. The measure is reported as an inverted rate. The formula for the Rate = (1 - (Numerator/Denominator)) x 100",
questionText: [
"The percentage of episodes for beneficiaries age 18 and older with a diagnosis of acute bronchitis/bronchiolitis that did not result in an antibiotic dispensing event.",
],
questionListItems: [],
categories,
qualifiers,
export const data: MeasureTemplateData = {
type: "HEDIS",
coreset: "adult",
performanceMeasure: {
customPrompt:
"Enter a number for the numerator and the denominator. The measure is reported as an inverted rate. The formula for the Rate = (1 - (Numerator/Denominator)) x 100",
questionText: [
"The percentage of episodes for beneficiaries age 18 and older with a diagnosis of acute bronchitis/bronchiolitis that did not result in an antibiotic dispensing event.",
],
questionListItems: [],
categories,
qualifiers,
},
custom: {
rateCalc: AABRateCalculation,
},
};
235 changes: 0 additions & 235 deletions services/ui-src/src/measures/2022/AABAD/index.test.tsx

This file was deleted.

Loading
Loading