(2022 - 2025) Remove Index.tsx from Measures #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailZhou
changed the title
BearHanded
previously approved these changes
Jan 17, 2025
rocio-desantiago
previously approved these changes
Jan 17, 2025
| @@ -146,13 +146,13 @@ describe("test measure floating bar menu", () => { | |||
| <RouterWrappedComp> | |||
| <MeasureWrapper | |||
| measure={ | |||
| <AABAD | |||
| <CPUAD | |||
| name={ | |||
| "Avoidance of Antibiotic Treatment for Acute Bronchitis/Bronchiolitis: Age 18 And Older" | |||
There was a problem hiding this comment.
Do we want to match the name and measureId for CPUAD here too?
There was a problem hiding this comment.
yeah we probably should for consistency sake. i'll make the changes in a less chonky PR. thanks!
| @@ -146,13 +146,13 @@ describe("test measure floating bar menu", () => { | |||
| <RouterWrappedComp> | |||
| <MeasureWrapper | |||
| measure={ | |||
| <AABAD | |||
| <CPUAD | |||
| name={ | |||
| "Avoidance of Antibiotic Treatment for Acute Bronchitis/Bronchiolitis: Age 18 And Older" | |||
| } | |||
| year={"2024"} | |||
| measureId={"AAB-AD"} | |||
There was a problem hiding this comment.
Should this be measureId={"CPU-AD"}
There was a problem hiding this comment.
will do the same as above for this one as well
ailZhou
dismissed stale reviews from rocio-desantiago and BearHanded
via
302f518
rocio-desantiago
previously approved these changes
Jan 21, 2025
benmartin-coforma
approved these changes
Jan 21, 2025
rocio-desantiago
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I know this PR is ridiculous and I'm really testing the limits of everyone's faith in me but I can promise that all the measures at least renders.
This is probably the last time I'll have a PR with 1000+ file changes.
Refer to previous pr for the same information as this PR.
Related ticket(s)
CMDCT-4242
How to test
Realistically there is no way to test all this in a reasonable amount of time, but we can lure ourselves into a false sense of assurance by clicking around and making sure the measures load and save.
Deploy Link: https://dcjatu2g4y7s8.cloudfront.net/
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod