-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMDCT-4086: Add / Edit Report Modal (NAAAR) #11920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Works as expected! Just a non-blocking nit and a question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I should add this to the description, but there is a separate ticket for the table: https://jiraent.cms.gov/browse/CMDCT-4116 |
Code Climate has analyzed commit 5c05882 and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Description
Finalizing the add / edit report modal for NAAAR, including the frontend and a couple of changes needed for the backend.
Related ticket(s)
CMDCT-4086
How to test
You should see the state name populating upon entering the first page of the report.
If you run
DYNAMO_ENDPOINT=http://localhost:8000 dynamodb-admin
in a new terminal and visitlocalhost:8001
you will see the report metadata as an entry.NOTE: The dashboard table is not populating correctly, there is a separate ticket to address this here
Notes
N/A
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod