Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMDCT-4086: Add / Edit Report Modal (NAAAR) #11920

Merged
merged 6 commits into from
Nov 14, 2024
Merged

CMDCT-4086: Add / Edit Report Modal (NAAAR) #11920

merged 6 commits into from
Nov 14, 2024

Conversation

karla-vm
Copy link
Collaborator

@karla-vm karla-vm commented Nov 12, 2024

Description

Finalizing the add / edit report modal for NAAAR, including the frontend and a couple of changes needed for the backend.

Related ticket(s)

CMDCT-4086


How to test

  • Log in as a state user
  • Create a NAAAR report
  • Click on the "Edit" icon to verify that the fields are hydrating correctly as well

You should see the state name populating upon entering the first page of the report.

If you run DYNAMO_ENDPOINT=http://localhost:8000 dynamodb-admin in a new terminal and visit localhost:8001 you will see the report metadata as an entry.

NOTE: The dashboard table is not populating correctly, there is a separate ticket to address this here

Notes

N/A


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

@karla-vm karla-vm marked this pull request as draft November 12, 2024 21:52
@karla-vm karla-vm marked this pull request as ready for review November 13, 2024 20:33
jessabean
jessabean previously approved these changes Nov 14, 2024
Copy link
Contributor

@jessabean jessabean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Works as expected! Just a non-blocking nit and a question.

Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the info populated in the dashboard table does not line up with the column names
i tested with both a custom and a provided plan type

Screenshot 2024-11-14 at 10 34 15 AM

@karla-vm
Copy link
Collaborator Author

the info populated in the dashboard table does not line up with the column names i tested with both a custom and a provided plan type

Screenshot 2024-11-14 at 10 34 15 AM

Good catch! I should add this to the description, but there is a separate ticket for the table: https://jiraent.cms.gov/browse/CMDCT-4116

Copy link

codeclimate bot commented Nov 14, 2024

Code Climate has analyzed commit 5c05882 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 4

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@karla-vm karla-vm merged commit d271cc3 into main Nov 14, 2024
17 checks passed
@karla-vm karla-vm deleted the cmdct-4086 branch November 14, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants