-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add first page reporting scenarios #11919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see a line at the bottom of MCPAR or MLR either. Was it there at some point?
Edit: I don't think the line has been part of the design in MCR. It's in MFP and could probably copy over the CSS from ReportPageFooter
there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty great to me. Did we need that state name auto populating in this PR too or is that a separate ticket?
General comment: we may want to look into refactoring the report page footer to match MFP. I think it's simpler in the other app, and the border is applied to that component instead of the content on each report page, so it's consistent wherever we use the footer. |
@ntsummers1 this will be a separate ticket (which i believe Karla already has ready!) #11920 |
Co-authored-by: Jessica Eldredge <[email protected]>
7224dee
Code Climate has analyzed commit 403c52e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Description
Add/update state information and reporting scenario page fields
Figma
See notes :)
Related ticket(s)
CMDCT-4097
How to test
Notes
The line separating fields from the footer buttons doesn't show up 🤔
Also the spacing is not exactly what's in the design. anyone think it's worth having the exact css in that hint text?
Pre-review checklist
[ ] I have added thorough tests, if necessary[ ] I have updated relevant documentation, if necessaryPre-merge checklist
Review