Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add first page reporting scenarios #11919

Merged
merged 5 commits into from
Nov 14, 2024
Merged

add first page reporting scenarios #11919

merged 5 commits into from
Nov 14, 2024

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Nov 12, 2024

Description

Add/update state information and reporting scenario page fields

Figma

See notes :)

Related ticket(s)

CMDCT-4097


How to test

  • Run app or view deployed instance
  • Log in as a state user
  • Create a NAAAR
  • Enter the report and verify the first page matches the figma
  • Fill out the page and verify it all works as expected (play around with nested "other text" field)

Notes

The line separating fields from the footer buttons doesn't show up 🤔

Also the spacing is not exactly what's in the design. anyone think it's worth having the exact css in that hint text?


Pre-review checklist

  • [ ] I have added thorough tests, if necessary
  • [ ] I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

@gmrabian gmrabian marked this pull request as ready for review November 13, 2024 14:53
@gmrabian gmrabian added help wanted Extra attention is needed ready for review Ready for all the reviews! design review Waiting for design review labels Nov 13, 2024
Copy link
Contributor

@bangbay-bluetiger bangbay-bluetiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see a line at the bottom of MCPAR or MLR either. Was it there at some point?

Edit: I don't think the line has been part of the design in MCR. It's in MFP and could probably copy over the CSS from ReportPageFooter there.

services/app-api/forms/naaar.json Outdated Show resolved Hide resolved
ntsummers1
ntsummers1 previously approved these changes Nov 13, 2024
Copy link
Contributor

@ntsummers1 ntsummers1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great to me. Did we need that state name auto populating in this PR too or is that a separate ticket?

@jessabean
Copy link
Contributor

General comment: we may want to look into refactoring the report page footer to match MFP. I think it's simpler in the other app, and the border is applied to that component instead of the content on each report page, so it's consistent wherever we use the footer.

@gmrabian
Copy link
Contributor Author

Looks pretty great to me. Did we need that state name auto populating in this PR too or is that a separate ticket?

@ntsummers1 this will be a separate ticket (which i believe Karla already has ready!) #11920

Co-authored-by: Jessica Eldredge <[email protected]>
Copy link

codeclimate bot commented Nov 14, 2024

Code Climate has analyzed commit 403c52e and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 96.7% (0.0% change).

View more on Code Climate.

@gmrabian gmrabian removed the help wanted Extra attention is needed label Nov 14, 2024
@gmrabian gmrabian merged commit 5d44889 into main Nov 14, 2024
17 checks passed
@gmrabian gmrabian deleted the cmdct-4097 branch November 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design review Waiting for design review ready for review Ready for all the reviews!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants