[1696] Refactored Tooltip implementation #1834
Open
+213
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-1
to
-6
| import 'package:ensemble/framework/event.dart'; | ||
| import 'package:ensemble/framework/extensions.dart'; | ||
| import 'package:ensemble/framework/theme/theme_manager.dart'; | ||
| import 'package:ensemble/widget/helpers/controllers.dart'; | ||
| import 'package:flutter/foundation.dart'; | ||
| import 'package:flutter/material.dart'; |
There was a problem hiding this comment.
why are we removing this, if aren't supporting this anymore, should we just add deprecated message.
PS: Ensemble react also has the Tooltip widget and is widely used in Atlas. Best case is we should create utils and support both. We don't want users to learn 2 languages for framework
CC: @kmahmood74
| borderRadius = Utils.getBorderRadius(inputs['borderRadius'])?.getValue(); | ||
| padding = Utils.optionalInsets(inputs['padding']); | ||
| margin = Utils.optionalInsets(inputs['margin']); | ||
| onTriggered = inputs['onTriggered'] != null ? |
There was a problem hiding this comment.
why onTriggered is part of tooltip styles?
isn't is a action, shouldn't it be a property, instead of a style?
onTooltipTriggered?
There was a problem hiding this comment.
actually instead of 3 new properties of tooltip, we should combine them in an map of 1 i.e tooltip
tooltip:
message:
onTriggered:
styles:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket: #1696
Once Approved will add schema and docs.
Example EDL is added in issue.
Docs: EnsembleUI/ensemble_docs#66
Schema: https://github.com/EnsembleUI/ensemble-web-studio/pull/1541
Recording:
https://github.com/user-attachments/assets/ba8eb279-424d-4c7e-9c00-d53a495a0c24