Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Tooltip Implementation to Utilize Properties instead of widget. #1017

Open
TheNoumanDev opened this issue Jan 31, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@TheNoumanDev
Copy link
Member

Title: Refactor Tooltip Implementation in ensemble_react to Property-based Approach

Description:
We need to align ensemble_react's tooltip implementation with ensemble_flutter by moving from a widget-based to a property-based approach.

Current State:

  • Tooltip is implemented as a wrapper widget
  • This approach goes against Ensemble's core design philosophy so we changed the ensemble_flutter appraoch as well.

Required Changes:

  1. Deprecation Steps:

    • Mark existing TooltipWidget as deprecated
    • Keep existing implementation temporarily for backward compatibility
  2. New Implementation:

  TextStyle? textStyle;
  double? verticalOffset;
  bool? preferBelow;
  Duration? waitDuration;
  Duration? showDuration;
  TooltipTriggerMode? triggerMode;
  Color? backgroundColor;
  BorderRadius? borderRadius;
  EdgeInsets? padding;
  EdgeInsets? margin;
  EnsembleAction? onTriggered;
  Color? borderColor;
  int? borderWidth;
  1. Schema Updates:
    • Remove TooltipWidget from schema validation
    • Add new tooltip properties to all widget schemas
    • Update documentation to reflect new approach

Referance Tickets:

@TheNoumanDev TheNoumanDev added the enhancement New feature or request label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant