Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use 'unstakeAndClaim' for visuals #4530

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

peachbits
Copy link
Contributor

@peachbits peachbits commented Oct 18, 2023

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

@peachbits peachbits force-pushed the matthew/unstakeAndClaim branch from e719276 to 27386ff Compare October 18, 2023 00:38
@peachbits
Copy link
Contributor Author

/rebase

The 'unstakeAndClaim' option is really just for visuals and text. Since the plugins don't use it as a unique action we should remove it from the ChangeQuoteRequest type and handle the special case where the user would see it.
@peachbits peachbits force-pushed the matthew/unstakeAndClaim branch from 27386ff to 2d3291f Compare October 19, 2023 19:11
@peachbits peachbits enabled auto-merge October 19, 2023 19:11
@peachbits peachbits merged commit 94dc9b3 into develop Oct 19, 2023
2 checks passed
@peachbits peachbits deleted the matthew/unstakeAndClaim branch October 19, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants