Remove 'unstakeAndClaim' as a ChangeQuoteRequest action

The 'unstakeAndClaim' option is really just for visuals and text. Since the plugins don't use it as a unique action we should remove it from the ChangeQuoteRequest type and handle the special case where the user would see it.
EdgeApp · Oct 19, 2023 · 2d3291f · 2d3291f
1 parent 2997289
commit 2d3291f
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 18 deletions.
diff --git a/src/components/scenes/Staking/StakeModifyScene.tsx b/src/components/scenes/Staking/StakeModifyScene.tsx
@@ -13,7 +13,7 @@ import { EdgeSceneProps } from '../../../types/routerTypes'
 import { getCurrencyIconUris } from '../../../util/CdnUris'
 import { getTokenId } from '../../../util/CurrencyInfoHelpers'
 import { getWalletName } from '../../../util/CurrencyWalletHelpers'
-import { getPolicyIconUris, getPolicyTitleName, getPositionAllocations } from '../../../util/stakeUtils'
+import { getPolicyIconUris, getPositionAllocations } from '../../../util/stakeUtils'
 import { toBigNumberString } from '../../../util/toBigNumberString'
 import { zeroString } from '../../../util/utils'
 import { SceneWrapper } from '../../common/SceneWrapper'
@@ -40,7 +40,7 @@ interface Props extends EdgeSceneProps<'stakeModify'> {
 
 const StakeModifySceneComponent = (props: Props) => {
   const { navigation, route, wallet } = props
-  const { modification, stakePlugin, stakePolicy, stakePosition } = route.params
+  const { modification, title, stakePlugin, stakePolicy, stakePosition } = route.params
   const { stakeWarning, unstakeWarning, claimWarning, disableMaxStake, mustMaxUnstake } = stakePolicy
   const existingAllocations = React.useMemo(() => getPositionAllocations(stakePosition), [stakePosition])
 
@@ -165,7 +165,6 @@ const StakeModifySceneComponent = (props: Props) => {
     const message = {
       stake: lstrings.stake_change_stake_success,
       unstake: lstrings.stake_change_unstake_success,
-      unstakeAndClaim: lstrings.stake_change_claim_success,
       claim: lstrings.stake_change_claim_success,
       unstakeExact: ''
     }
@@ -458,16 +457,6 @@ const StakeModifySceneComponent = (props: Props) => {
     )
   }
 
-  const sceneTitleMap = React.useMemo(() => {
-    return {
-      stake: getPolicyTitleName(stakePolicy),
-      claim: lstrings.stake_claim_rewards,
-      unstake: lstrings.stake_unstake,
-      unstakeAndClaim: lstrings.stake_unstake_claim,
-      unstakeExact: '' // Only for internal use
-    }
-  }, [stakePolicy])
-
   const policyIcons = getPolicyIconUris(wallet.currencyInfo, stakePolicy)
   const icon = React.useMemo(
     () => (modification === 'stake' ? null : <Image style={styles.icon} source={{ uri: policyIcons.rewardAssetUris[0] }} />),
@@ -487,7 +476,7 @@ const StakeModifySceneComponent = (props: Props) => {
   return (
     <SceneWrapper scroll background="theme">
       <ScrollView>
-        <SceneHeader style={styles.sceneHeader} title={sceneTitleMap[modification]} underline withTopMargin>
+        <SceneHeader style={styles.sceneHeader} title={title} underline withTopMargin>
           {icon}
         </SceneHeader>
         {renderChangeQuoteAmountTiles(modification)}

diff --git a/src/components/scenes/Staking/StakeOverviewScene.tsx b/src/components/scenes/Staking/StakeOverviewScene.tsx
@@ -82,13 +82,27 @@ const StakeOverviewSceneComponent = (props: Props) => {
   }, [account, stakePlugin, stakePolicyId, updateCounter, wallet])
 
   // Handlers
-  const handleModifyPress = (modification: ChangeQuoteRequest['action']) => () => {
+  const handleModifyPress = (modification: ChangeQuoteRequest['action'] | 'unstakeAndClaim') => () => {
+    const sceneTitleMap = {
+      stake: getPolicyTitleName(stakePolicy),
+      claim: lstrings.stake_claim_rewards,
+      unstake: lstrings.stake_unstake,
+      unstakeAndClaim: lstrings.stake_unstake_claim,
+      unstakeExact: '' // Only for internal use
+    }
+    const title = sceneTitleMap[modification]
+
+    if (modification === 'unstakeAndClaim') {
+      modification = 'unstake'
+    }
+
     if (stakePosition != null && stakeAllocations != null && rewardAllocations != null) {
       navigation.navigate('stakeModify', {
         modification,
         stakePlugin,
         stakePolicy,
         stakePosition,
+        title,
         walletId: wallet.id
       })
     }

diff --git a/src/plugins/stake-plugins/thorchainSavers/tcSaversPlugin.ts b/src/plugins/stake-plugins/thorchainSavers/tcSaversPlugin.ts
@@ -647,7 +647,7 @@ const unstakeRequestInner = async (opts: EdgeGuiPluginOptions, request: ChangeQu
     // Only unstake the exact amount specified in the request.nativeAmount
     totalUnstakeNativeAmount = nativeAmount
   } else {
-    // If action === claim || action === unstakeAndClaim
+    // If action === claim
     // The user will be explicitly unstaking the earned amount
     totalUnstakeNativeAmount = earnedAmount
   }
@@ -789,7 +789,6 @@ const unstakeRequestInner = async (opts: EdgeGuiPluginOptions, request: ChangeQu
 const changeQuoteFuncs = {
   stake: stakeRequest,
   unstake: unstakeRequest,
-  unstakeAndClaim: unstakeRequest,
   claim: unstakeRequest,
   unstakeExact: unstakeRequest
 }

diff --git a/src/plugins/stake-plugins/types.ts b/src/plugins/stake-plugins/types.ts
@@ -107,7 +107,7 @@ export interface StakePolicy {
 // Change Quote
 // -----------------------------------------------------------------------------
 export interface ChangeQuoteRequest {
-  action: 'stake' | 'unstake' | 'unstakeAndClaim' | 'claim' | 'unstakeExact'
+  action: 'stake' | 'unstake' | 'claim' | 'unstakeExact'
   stakePolicyId: string
   currencyCode: string
   nativeAmount: string

diff --git a/src/types/routerTypes.tsx b/src/types/routerTypes.tsx
@@ -270,6 +270,7 @@ export interface RouteParamList {
   settingsOverviewTab: {}
   spendingLimits: {}
   stakeModify: {
+    title: string
     stakePlugin: StakePlugin
     walletId: string
     stakePolicy: StakePolicy