Emulate legacy rm2k/3 move picture behavior + refactor engine accessors #1969
Conversation
mateofio
changed the title
|
I found a japanese RPG_RT 1.0.3 and discovered it also has the same move picture behavior, so I redid this to be more general. Needs to be reviewed again. |
mateofio
force-pushed
the
oldpic
branch
3 times, most recently
from
8e914be to
6ffe6fe
Compare
| bool IsLegacy(); | ||
|
|
||
| /** @return If engine is RPG2kUpdated() or RPG2k3Updated() */ | ||
| bool IsMajorUpdatedVersion(); |
There was a problem hiding this comment.
You changed the range of the functions, e.g. before "IsMajorUpdated" was "Everything not Legacy" and now it is "Every not Legacy and not English/Steam" or are the comments misleading?
When this is intended we need a better naming here. Maybe split between 2kE and 2kJ and for J add additional split 2kJLegacy and 2kJUpdated?
There was a problem hiding this comment.
I can change the comments, updated should just be >=
We do need better naming. And maybe even finer grained control. Because there are major features differences between these lines. For this PR I just wanted to clean it up a little and support legacy rm2k3, but not completely redo it as I am not yet sure what it should look like.
* Make inline and add more accessors * Fix comments * Remove FIXME about number of pictures in 2k3 legacy (confirmed) * Change IsRPG2k3Legacy() to mean < 1.0.5
MovePicture command doesn't change position of pictures with fixed_to_map chunk set. Used in Destined game See: EasyRPG#1741
MovePicture command doesn't change position of pictures
with fixed_to_map chunk set.
Used in Destined game See: #1741
Confirmed with Don's rm2k and Japanese rm2k3 RPG_RT 1.0.3