Skip to content

Start of ImGUI UI #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Mar 8, 2025
Merged

Start of ImGUI UI #6

merged 38 commits into from
Mar 8, 2025

Conversation

evaan
Copy link
Member

@evaan evaan commented Dec 21, 2024

No description provided.

Copy link
Contributor

@Zaid-Duraid Zaid-Duraid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compiled this locally and it looks good, I really like the way it was done!

Overall, as I suggested to you a few times initially, I would ensure that you know where we already stand with our existing code in order to not reimplement features. I was worried this would happen which is why I tried to give you a run-down of what we have. If you are unsure about our existing structure and/or what we have done so far, feel free to look at previous commits/pull-requests or let me know.

Also, it would be nice to make the frontend ROV-agnostic as I discussed. I plan to do soon with our web frontend. However this is definitely something we can discuss.

I will end my review by requesting some changes. All in all I don't think they will take a long time to implement and I can definitely help with a lot of it. If you have questions please let me know!

@Zaid-Duraid Zaid-Duraid dismissed their stale review March 8, 2025 05:52

Branch looks good now and is ready for merge

Copy link
Contributor

@Zaid-Duraid Zaid-Duraid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Zaid-Duraid Zaid-Duraid merged commit 66091d4 into main Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants