-
Notifications
You must be signed in to change notification settings - Fork 0
Start of ImGUI UI #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compiled this locally and it looks good, I really like the way it was done!
Overall, as I suggested to you a few times initially, I would ensure that you know where we already stand with our existing code in order to not reimplement features. I was worried this would happen which is why I tried to give you a run-down of what we have. If you are unsure about our existing structure and/or what we have done so far, feel free to look at previous commits/pull-requests or let me know.
Also, it would be nice to make the frontend ROV-agnostic as I discussed. I plan to do soon with our web frontend. However this is definitely something we can discuss.
I will end my review by requesting some changes. All in all I don't think they will take a long time to implement and I can definitely help with a lot of it. If you have questions please let me know!
Changes the format of the profiles and stores them in a JSON file
corrected with comments
added comments and cleaned code
Branch looks good now and is ready for merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
No description provided.