Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*New baselines for tx2_3v2 05/03/2024 #162

Merged
merged 12 commits into from
May 10, 2024

Conversation

gustavo-marques
Copy link
Collaborator

Copy link
Member

@alperaltuntas alperaltuntas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be at least two issues:

(1) I am getting the following error for g16, t061, and t025 grids. Granted we will soon remove g16 and t061, but I think we should extend KV for all tested grids for now:

FATAL from PE     0: read_param_real: Unable to find variable KV in any input files.

(2) The SMS_D.TL319_t232.GMOM_JRA_RYF.derecho_intel tests fails. This test is run with DEBUG=TRUE and there doesn't seem to be a descriptive error message.

@gustavo-marques
Copy link
Collaborator Author

@alperaltuntas, thanks for reviewing this. I have now defined KV for all grids.

@@ -824,6 +833,7 @@ Global:
HYBRID:vgrid.nc,sigma2,dz"
datatype: string
value:
$MOM6_VERTICAL_GRID == "zstar_65L": '"FILE:zstar_75layer_2.5m_248.4m-2024-03-29.nc,dz"'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be zstar_75L? zstar_65L is in the next block.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, Mike. This has been fixed in the last commit.

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

@gustavo-marques
Copy link
Collaborator Author

@alperaltuntas; please re-evaluate this PR using NCAR/MOM6#279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants