Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set KD=0, KV=0 #135

Closed
wants to merge 2 commits into from
Closed

Set KD=0, KV=0 #135

wants to merge 2 commits into from

Conversation

dcherian
Copy link

Closes #134

@dcherian dcherian mentioned this pull request Mar 22, 2023
Open
alperaltuntas
alperaltuntas requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@alperaltuntas alperaltuntas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to run the ./yaml_to_json script after making changes in yaml template files. This should have been caught by the CI test, but seems like the test is broken. I will create an issue.

@alperaltuntas alperaltuntas mentioned this pull request Mar 30, 2023
Closed
4 tasks
@dcherian
Copy link
Author

@ALDepp ran with these settings in user_nl_mom and the output is here: /glade/campaign/cgd/oce/projects/pump/cesm/archive/gmom.e23.GJRAv3.TL319_t061_zstar_N65.new_baseline.hb/run

it would be good to compare Gustavo's diagnostics with the previous baseline before merging here

@gustavo-marques
Copy link
Collaborator

These changes were incorporated in #162

@dcherian dcherian deleted the zero-KD-KV branch May 18, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperaltuntas alperaltuntas alperaltuntas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small correction to the background diffusivity and viscosity
3 participants
@dcherian @gustavo-marques @alperaltuntas