-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6 feed active command #33
Conversation
@GloryBoyK This is the PR that caused the lost code, I don't know what happened but somehow I approved code that removed vital stuff |
I need to be more careful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really missed some big mistakes in reviewing this code. I need to be more thorough in my review, it's important to get this stuff right. There's no rush to review because we are way ahead of schedule as programming team, and an incorrect approval can be very costly later on. Right now it's best to take our time and be accurate. (talking to me more than anyone else)
what are the logistics of us reverting this merge? we might wanna look into that @a1cd |
Reverting is sorta last resort stuff or for when we don't want any of the changes made (ever) in our code. Reverting is irreversible. cannot revert and then merge again |
No description provided.