Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6 feed active command #33

Merged
merged 4 commits into from
Jan 21, 2024
Merged

6 feed active command #33

merged 4 commits into from
Jan 21, 2024

Conversation

GBKP
Copy link
Contributor

@GBKP GBKP commented Jan 20, 2024

No description provided.

@GBKP GBKP linked an issue Jan 20, 2024 that may be closed by this pull request
@GBKP GBKP requested a review from a1cd January 20, 2024 17:16
@a1cd a1cd merged commit 1d780f6 into main Jan 21, 2024
2 checks passed
@a1cd
Copy link
Contributor

a1cd commented Jan 30, 2024

@GloryBoyK This is the PR that caused the lost code, I don't know what happened but somehow I approved code that removed vital stuff

@a1cd
Copy link
Contributor

a1cd commented Jan 30, 2024

I need to be more careful

Copy link
Contributor

@a1cd a1cd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really missed some big mistakes in reviewing this code. I need to be more thorough in my review, it's important to get this stuff right. There's no rush to review because we are way ahead of schedule as programming team, and an incorrect approval can be very costly later on. Right now it's best to take our time and be accurate. (talking to me more than anyone else)

src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Show resolved Hide resolved
@a1cd a1cd mentioned this pull request Jan 30, 2024
@GBKP
Copy link
Contributor Author

GBKP commented Jan 30, 2024

what are the logistics of us reverting this merge? we might wanna look into that @a1cd

@a1cd
Copy link
Contributor

a1cd commented Jan 31, 2024

Reverting is sorta last resort stuff or for when we don't want any of the changes made (ever) in our code. Reverting is irreversible. cannot revert and then merge again

@a1cd a1cd deleted the 6-feed-active-command branch February 5, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feed Active Command
3 participants