Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with removed code #41

Closed
a1cd opened this issue Jan 30, 2024 · 0 comments · Fixed by #42
Closed

Problem with removed code #41

a1cd opened this issue Jan 30, 2024 · 0 comments · Fixed by #42
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@a1cd
Copy link
Contributor

a1cd commented Jan 30, 2024

@GloryBoyK I made a mistake in reviewing your code. That means I missed a mistake in your PR. It looks like a simple problem in a merge conflict while updating git but I should have caught that in the review. I don't know how I missed that issue. Anyways, gotta get those fixed for code to work so sort of top priority rn.

I really missed some big mistakes in reviewing this code. I need to be more thorough in my review, it's important to get this stuff right. There's no rush to review because we are way ahead of schedule as programming team, and an incorrect approval can be very costly later on. Right now it's best to take our time and be accurate. (talking to me more than anyone else)

Originally posted by @a1cd in #33 (review)

@a1cd a1cd added the help wanted Extra attention is needed label Jan 30, 2024
@a1cd a1cd added this to the Drivetrain milestone Jan 30, 2024
@a1cd a1cd pinned this issue Jan 30, 2024
@a1cd a1cd assigned A0Prakash and GBKP and unassigned A0Prakash Jan 30, 2024
@GBKP GBKP linked a pull request Jan 30, 2024 that will close this issue
@a1cd a1cd closed this as completed in #42 Jan 30, 2024
@a1cd a1cd unpinned this issue Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants