#734: Http Integration tests for COMMAND and COMMAND/COUNT

[svkaizoku]

Fixes: #734

I will be splitting the implementation of this issue in multiple PR's.

The PR contains tests to for the below commands

• COMMAND/COUNT : command_count_test.go
• COMMAND: command_default_test.go

[svkaizoku]

@lucifercr07 @pratikpandey21 , feel free to review this whenever free. Thanks :D

[lucifercr07]

@svkaizoku build is failing can you please have a look?

[svkaizoku]

@svkaizoku build is failing can you please have a look?

Yes, let me do it.

[svkaizoku]

@lucifercr07 Done 👍

[lucifercr07]

We can add one more scenario for below case

redis> COMMAND COUNT 123
(error) wrong number of arguments for 'command|count' command

[lucifercr07]

@svkaizoku please resolve comments and conflicts.

[svkaizoku]

@lucifercr07 on it. Will do it today.

[lucifercr07]

@svkaizoku build is failing, please have a look.

[svkaizoku]

@svkaizoku build is failing, please have a look.

@lucifercr07

@svkaizoku build is failing, please have a look.

Hey @lucifercr07
I need to send empty body for the request. But i am not sure how to do it though.
{
name: "Command count should be positive",
commands: []HTTPCommand{
{Command: "COMMAND/COUNT", Body: map[string]interface{}{}},
},
expected: []interface{}{float64(123)},
}

If i do this, an Invalid HTTP request format error is coming. i have asked the same in discord, can you point me to an example if you know?

What is the use case for this error?

dice/internal/server/utils/redisCmdAdapter.go

Line 76 in 97e435c

if len(jsonBody) == 0 {

Can i remove this?

[svkaizoku]

@svkaizoku build is failing, please have a look.

@lucifercr07

@svkaizoku build is failing, please have a look.

Hey @lucifercr07 I need to send empty body for the request. But i am not sure how to do it though. { name: "Command count should be positive", commands: []HTTPCommand{ {Command: "COMMAND/COUNT", Body: map[string]interface{}{}}, }, expected: []interface{}{float64(123)}, }

If i do this, an Invalid HTTP request format error is coming. i have asked the same in discord, can you point me to an example if you know?

What is the use case for this error?

dice/internal/server/utils/redisCmdAdapter.go

Line 76 in 97e435c

if len(jsonBody) == 0 {

Can i remove this?

No need to remove it. Have updated ability to add empty body in tests.

[svkaizoku]

@svkaizoku build is failing, please have a look.

@lucifercr07 it is fixed and no conflicts now. Can you take a look now?