Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Integration Tests: Create tests to support HTTP #734

Closed
pratikpandey21 opened this issue Sep 26, 2024 · 8 comments · Fixed by #899 or #900
Closed

Http Integration Tests: Create tests to support HTTP #734

pratikpandey21 opened this issue Sep 26, 2024 · 8 comments · Fixed by #899 or #900

Comments

@pratikpandey21
Copy link
Contributor

This issue involves creating the below test cases for HTTP as well:

Source: integration_tests/commands/async/

  • bit_operation_test.go
  • bit_ops_string_int_test.go
  • check_type_test.go
  • command_count_test.go
  • command_default_test.go

Steps:

  1. Create the corresponding tests for these commands in integration_tests/commands/http.
  2. Use set_test.go as a reference, and how to alter the input and output to match JSON structures from RESP.
  3. Run the tests and fix issues with command parsing in HTTP.

If you need to do anything custom to support HTTP, let @pratikpandey21 @lucifercr07 know.

@svkaizoku
Copy link
Contributor

Hey @pratikpandey21 , I would like to pick this up. Can you add the tag if this will be a good first issue? I am new to go, but would like to take dig at this issue. wdyt?

@lucifercr07
Copy link
Contributor

@svkaizoku assigned, thanks for contributing. This issue should be good for you to start with.

@svkaizoku
Copy link
Contributor

Thanks @lucifercr07 , will start work on it over the weekend :)

@arpitbbhayani
Copy link
Contributor

Hello @svkaizoku,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@svkaizoku
Copy link
Contributor

Hey @arpitbbhayani , I am actively working on this. I am creating separate PR's for these, that are referenced in this issue as as you can see above. Currently I am not stuck in anything. Will reach out in discord if any. Thanks :D

@svkaizoku
Copy link
Contributor

@svkaizoku
Copy link
Contributor

Hey @lucifercr07 , I am unabe to write proper tests for bit_operation_test.go,bit_ops_string_int_test.go
due to this issue #942 .
As you can see from this Http Integration Tests for Bit Operations , I have covered half of the working cases, but there seems to be issues with encoding. Once the issue is fixed, it would make sense to write proper tests for it.

@svkaizoku
Copy link
Contributor

@JyotinderSingh can we reopen it. The whole task is not completed yet as tests for

Hey @lucifercr07 , I am unabe to write proper tests for bit_operation_test.go,bit_ops_string_int_test.go due to this issue #942 . As you can see from this Http Integration Tests for Bit Operations , I have covered half of the working cases, but there seems to be issues with encoding. Once the issue is fixed, it would make sense to write proper tests for it.

@JyotinderSingh can we reopen this issue as it is not completed due to it being blocked by the above mentioned issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment