Add support for command JSON.STRAPPEND #501

[karandixit10]

Fixes #501

Description

This pull request adds support for JSON.STRAPPEND command

[apoorvyadav1111]

Hi, looks good to me, just left a few suggestions. Thanks

[apoorvyadav1111]

Hi, the changes look good to me. Thank you for addressing the comments.

[karandixit10]

@lucifercr07 can you merge this PR it's been reviewed

[lucifercr07]

@karandixit10 please resolve conflicts.

[lucifercr07]

Is this change in line with Redis output?

[karandixit10]

Hi, this return can to be updated. Currently the message in dice is: But in redis: I understand we have to replace dice with redis, but we have an extra ERR in the message which can be removed if we modify the object.AssertTypeAndEncoding with the following change:

func AssertTypeAndEncoding(typeEncoding, expectedType, expectedEncoding uint8) []byte {
	if err := AssertType(typeEncoding, expectedType); err != nil {
		return diceerrors.NewErrWithMessage(diceerrors.WrongKeyTypeErr)
	}
	if err := AssertEncoding(typeEncoding, expectedEncoding); err != nil {
		return diceerrors.NewErrWithMessage(diceerrors.WrongKeyTypeErr)
	}
	return nil
}

and add the following error in errors.go file:

	WrongKeyTypeErr        = "-Existing key has wrong Dice type"

How do you feel about this suggestion.

Yeah It's same as the Dice output

[lucifercr07]

I don't think it's correct, if you pass a message prefixed with - it's not prefixed with an error.
We don't need to change all the test cases in this case.

// NewErrWithMessage If the error code is already passed in the string,
// the error code provided is used, otherwise the string "-ERR " for the generic
// error code is automatically added. Note that 's' must NOT end with \r\n.
func NewErrWithMessage(errMsg string) []byte {
	// If the string already starts with "-..." then the error code
	// is provided by the caller. Otherwise, we use "-ERR".
	if errMsg == "" || errMsg[0] != '-' {
		errMsg = fmt.Sprintf(ErrDefault, errMsg)
	}

	return newDiceErr(errMsg).toEncodedMessage()
}

[karandixit10]

Ok I'll revert it back to original

[karandixit10]

Hi @lucifercr07 I have made the changes you can merge this now

[karandixit10]

Hi @lucifercr07 conflicts are coming now, I'll fix those please merge them after that.

[lucifercr07]

LGTM, please resolve conflicts. We can merge.

[karandixit10]

Hi @lucifercr07 , Resolved the confilcts.