Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command JSON.STRAPPEND #501

Closed
arpitbbhayani opened this issue Sep 8, 2024 · 14 comments · Fixed by #882
Closed

Add support for command JSON.STRAPPEND #501

arpitbbhayani opened this issue Sep 8, 2024 · 14 comments · Fixed by #882
Assignees
Labels

Comments

@arpitbbhayani
Copy link
Contributor

arpitbbhayani commented Sep 8, 2024

Add support for the JSON.STRAPPEND command in DiceDB similar to the JSON.STRAPPEND command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@rishu1601
Copy link

@arpitbbhayani - Can you please assign this to me? I am new to the dicedb world, looking forward to tackle this

@lucifercr07
Copy link
Contributor

@rishu1601 assigned, thanks for picking this up.

@jainbhavya53
Copy link
Contributor

Hi @lucifercr07
Is this still being worked upon ? Otherwise I'll be happy to pick this up.
Thanks

@lucifercr07
Copy link
Contributor

@rishu1601 can you please share updates on the issue?

@rishu1601
Copy link

rishu1601 commented Sep 17, 2024 via email

@karandixit10
Copy link
Contributor

Hi @lucifercr07 Can I pick this up if no one working on it?

@lucifercr07
Copy link
Contributor

@karandixit10 will assign on Monday if no updates by then.

@psrvere
Copy link
Contributor

psrvere commented Sep 24, 2024

@lucifercr07 - I can pick this up if it's available.

@lucifercr07
Copy link
Contributor

@psrvere will assign this to @karandixit10 for now as he had already asked earlier. For upcoming issues will try to assign.

@karandixit10
Copy link
Contributor

@lucifercr07 will start this from tomorrow, I'll try to complete it by tomorrow.

@karandixit10
Copy link
Contributor

@lucifercr07 I have implemented this just need to add integration tests and unit tests for this

karandixit10 added a commit to karandixit10/dice that referenced this issue Sep 30, 2024
karandixit10 added a commit to karandixit10/dice that referenced this issue Sep 30, 2024
karandixit10 added a commit to karandixit10/dice that referenced this issue Oct 2, 2024
@arpitbbhayani
Copy link
Contributor Author

Hello @karandixit10,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@karandixit10
Copy link
Contributor

Hi @arpitbbhayani ,
I have already implemented this and it's already been reviewed in this PR #882 , Just waiting for it to get merge.

Thanks.

karandixit10 added a commit to karandixit10/dice that referenced this issue Oct 4, 2024
karandixit10 added a commit to karandixit10/dice that referenced this issue Oct 5, 2024
karandixit10 added a commit to karandixit10/dice that referenced this issue Oct 8, 2024
@arpitbbhayani
Copy link
Contributor Author

Hello @karandixit10,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

karandixit10 added a commit to karandixit10/dice that referenced this issue Oct 11, 2024
sashpawar11 pushed a commit to sashpawar11/dice that referenced this issue Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants