Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#735: tests: COMMAND GETKEYS, COMMAND INFO, COMMAND LIST, COMMAND RENAME, COPY #768

Merged
merged 6 commits into from
Oct 4, 2024
Merged

#735: tests: COMMAND GETKEYS, COMMAND INFO, COMMAND LIST, COMMAND RENAME, COPY #768

merged 6 commits into from
Oct 4, 2024

Conversation

Indranil0603
Copy link
Contributor

@Indranil0603 Indranil0603 commented Sep 28, 2024 •
edited
Loading

for #735

Adds support for subcommands using HTTP, and integrations tests for HTTP support of the following commands

Changes:

  • redisCmdAdapter.go - added support for subcommands
  • command_getkeys_test.go - Integration test for COMMAND GETKEYS
  • command_info_test.go - Integration test for COMMAND INFO
  • command_list_test.go - Integration test for COMMAND LIST
  • command_rename_test.go - Integration test for COMMAND RENAME
  • copy_test.go - Integration test for COPY

pratikpandey21
pratikpandey21 reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@pratikpandey21 pratikpandey21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a few comments

internal/server/utils/redisCmdAdapter.go Outdated Show resolved Hide resolved
integration_tests/commands/http/command_getkeys_test.go Outdated Show resolved Hide resolved
@Indranil0603 Indranil0603 changed the title tests: COMMAND GETKEYS tests: COMMAND GETKEYS, COMMAND INFO, COMMAND LIST, COMMAND RENAME, COMMAND COPY Sep 30, 2024
@Indranil0603 Indranil0603 changed the title tests: COMMAND GETKEYS, COMMAND INFO, COMMAND LIST, COMMAND RENAME, COMMAND COPY tests: COMMAND GETKEYS, COMMAND INFO, COMMAND LIST, COMMAND RENAME, COPY Sep 30, 2024
@Indranil0603 Indranil0603 marked this pull request as ready for review September 30, 2024 15:39
@svkaizoku svkaizoku mentioned this pull request Oct 1, 2024
Merged
@JyotinderSingh
Copy link
Collaborator

Please resolve conflicts, will merge once done.

@Indranil0603
Copy link
Contributor Author

@JyotinderSingh i have resolved the conflicts

@JyotinderSingh JyotinderSingh changed the title tests: COMMAND GETKEYS, COMMAND INFO, COMMAND LIST, COMMAND RENAME, COPY #735: tests: COMMAND GETKEYS, COMMAND INFO, COMMAND LIST, COMMAND RENAME, COPY Oct 4, 2024
@JyotinderSingh JyotinderSingh merged commit 3795c7d into DiceDB:master Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikpandey21 pratikpandey21 pratikpandey21 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Indranil0603 @JyotinderSingh @pratikpandey21