Add integration tests #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosesyrett
force-pushed
the
add_integration_tests
branch
from
1f2452a
to
0b6e4fb
Compare
rosesyrett
force-pushed
the
76_running_event
branch
from
0660126
to
eed8af4
Compare
rosesyrett
added a commit
that referenced
this pull request
Jul 18, 2023
#160) Remove asyncio.wait deprecation warning by only passing tasks to it. In the master scheduler _do_task method, a coroutine is passed to asyncio.wait. This is deprecated behaviour. I noticed this while working on #153: ``` File "/workspace/tickit/src/tickit/core/management/schedulers/master.py", line 102, in _do_tick which, _ = await asyncio.wait( File "/usr/local/lib/python3.10/asyncio/tasks.py", line 377, in wait warnings.warn("The explicit passing of coroutine objects to " DeprecationWarning: The explicit passing of coroutine objects to asyncio.wait() is deprecated since Python 3.8, and scheduled for removal in Python 3.11. ```
added 8 commits
July 18, 2023 09:16
rosesyrett
force-pushed
the
add_integration_tests
branch
from
2345d5d
to
effc3ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 94.50% 95.12% +0.61%
==========================================
Files 44 44
Lines 1292 1292
==========================================
+ Hits 1221 1229 +8
+ Misses 71 63 -8 |
abbiemery
reviewed
Jul 21, 2023
This change introduces simple type aliases to improve readability for distinguishing between component input and output types.
This change shifts the simulation builder logic from the cli to a dedicated class, TickitSimulation. It adds a builder function to allow simulations to be constructed in a declarative fashion, allowing for further customisation in the future and better testing now. It is a step towards the larger changes required for simulating zebra devices and uniting master and nested simulation logic.
- No longer required for supported versions of python
abbiemery
reviewed
Jul 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the master and slave scheduler in context with other components, with minimal mocking and test configurations.
Two test cases are set up; one for a regular simulation with a master scheduler, sink and source. Another for a simulation with a system simulation component. A fixture sets up the simulation and yields it before the tests, tearing it down afterwards by throwing an exception and device interrupt.