Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scheduler tests #122

Closed
abbiemery opened this issue Apr 18, 2023 · 2 comments
Closed

Update scheduler tests #122

abbiemery opened this issue Apr 18, 2023 · 2 comments
Assignees
@rosesyrett

Comments

@abbiemery
Copy link
Collaborator

Many of the existing tests only test implementation and don't really test actual behaviour. Now there is a mechanism in place to shut things down gracefully, It would be good to have these rewritten to:

  1. Test behaviour
  2. Be typed correctly, allowing us to remove the "#ignore"s

This should be feasible with the addition of #76 .
@abbiemery
Copy link
Collaborator Author

For base, master and slave scheduler.

@abbiemery
Copy link
Collaborator Author

Closed with #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosesyrett rosesyrett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abbiemery @rosesyrett