Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

87 small test plan for the pressure cell alone #93

Merged
merged 11 commits into from
Nov 14, 2024
Merged

87 small test plan for the pressure cell alone #93

merged 11 commits into from
Nov 14, 2024

Conversation

stan-dot
Copy link
Collaborator

@stan-dot stan-dot commented Aug 5, 2024

No description provided.

@stan-dot stan-dot added enhancement New feature or request python Pull requests that update Python code labels Aug 5, 2024
@stan-dot stan-dot self-assigned this Aug 5, 2024
@stan-dot stan-dot linked an issue Aug 5, 2024 that may be closed by this pull request
Small test plan for the pressure cell in isolation #87
Closed
@stan-dot stan-dot force-pushed the 87-small-test-plan-for-the-pressure-cell-alone branch from 0c2b2d3 to f5356ef Compare August 5, 2024 13:16
DiamondJoseph
DiamondJoseph previously requested changes Aug 5, 2024
View reviewed changes
src/i22_bluesky/plans/test_pressure_cell.py Outdated Show resolved Hide resolved
@stan-dot
Copy link
Collaborator Author

@DiamondJoseph this is problematic without a scratch directory. the CI is failing. should I hard code a git commit sha for the pressure cell commit?

the parallel development of plans and devices is a bit of a pain point

@DiamondJoseph
Copy link
Contributor

@DiamondJoseph this is problematic without a scratch directory. the CI is failing. should I hard code a git commit sha for the pressure cell commit?

the parallel development of plans and devices is a bit of a pain point

Get your devices at least initial implementation merged into dodal, otherwise you're shooting at a moving target

@stan-dot
Copy link
Collaborator Author

that is the relevant PR DiamondLightSource/dodal#673

@stan-dot stan-dot force-pushed the 87-small-test-plan-for-the-pressure-cell-alone branch from 5fb58f1 to 05eda2d Compare August 30, 2024 10:18
@stan-dot stan-dot marked this pull request as ready for review October 2, 2024 14:28
@stan-dot stan-dot force-pushed the 87-small-test-plan-for-the-pressure-cell-alone branch from 05eda2d to 44c52f0 Compare October 2, 2024 14:34
@stan-dot stan-dot merged commit 3a416e8 into main Nov 14, 2024
12 of 16 checks passed
@stan-dot stan-dot deleted the 87-small-test-plan-for-the-pressure-cell-alone branch November 14, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumforrester callumforrester Awaiting requested review from callumforrester

@DiamondJoseph DiamondJoseph Awaiting requested review from DiamondJoseph

Assignees

@stan-dot stan-dot

Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small test plan for the pressure cell in isolation
3 participants
@stan-dot @DiamondJoseph @callumforrester