Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small test plan for the pressure cell in isolation #87

Closed
stan-dot opened this issue Jul 17, 2024 · 3 comments · Fixed by #93
Closed

Small test plan for the pressure cell in isolation #87

stan-dot opened this issue Jul 17, 2024 · 3 comments · Fixed by #93
Assignees
Labels
enhancement New feature or request python Pull requests that update Python code

Comments

@stan-dot
Copy link
Collaborator

tests DiamondLightSource/dodal#658

@stan-dot stan-dot added enhancement New feature or request python Pull requests that update Python code labels Jul 17, 2024
@stan-dot stan-dot self-assigned this Jul 17, 2024
@stan-dot
Copy link
Collaborator Author

tagging @barnettwilliam
steps to set this up:

  1. get the cluster based on the cloud computing ticket
  2. go to daq-deployments and source the p38/.env file to get the env constants
  3. get into the local k8s CLI with module load $CLUSTER
  4. run .deploy.sh inside daq-deploy to execute the helm command
  5. check if the blueapi url works /docs
  6. make sure maybe ingress point is needed to get the url into DNS
  7. but should work with ip addresss without dns
  8. then make sure blueapi lists the plans from i22-bluesky (loaded in /dls_sw/p38/software/blueapi/scratch)
  9. make sure that dodal is also checked out (at the right branch) in this location
  10. then we have 1 blueapi which loads 2 dodal device and 3 plans
  11. now you can run the new plan with POST /task endpoint. remember that first the plan needs to be visible in the listed plans and you need to call it with the right arguments.
  12. let's just run from the swagger ui for now, let's set aside the GDA interface for later
  13. the plan should test the cell to various pressures and it must return the MsgGenerator type to be listed as a runnable plan

@stan-dot stan-dot changed the title Small test plan for the pressure cell alone Small test plan for the pressure cell in isolation Jul 18, 2024
@stan-dot
Copy link
Collaborator Author

stan-dot commented Aug 2, 2024

In order to pressurise the sample V3 and either V5, or V6, needs to be open

is what I learned, let's try this

@stan-dot stan-dot linked a pull request Aug 5, 2024 that will close this issue
@stan-dot
Copy link
Collaborator Author

based on the draft for the whole plan ( #79 (comment)) , this would be just raising the pressure in the controlllers and then reading back with a different subpart of the cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant