Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Use the bit depth from the detector to work out what VDS data type to use #1172

Merged
merged 7 commits into from
Feb 20, 2024

Conversation

DominicOram
Copy link
Collaborator

@DominicOram DominicOram commented Feb 19, 2024

Fixes #1162

To test:

  1. Confirm new tests pass and correctly check the VDS type

@DominicOram DominicOram marked this pull request as ready for review February 20, 2024 11:21
@DominicOram
Copy link
Collaborator Author

See #1173 for some tidying up I would like to do after this

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good solution! I think it would be nice if we did it this way for xray centring as well at some point

EDIT: Just seen you've already mentioned that in linked issue

@olliesilvester olliesilvester merged commit 91d21c6 into main Feb 20, 2024
6 checks passed
@olliesilvester olliesilvester deleted the 1162_16_bit_vds branch February 20, 2024 14:45
olliesilvester added a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/1162_16_bit_vds

Use the bit depth from the detector to work out what VDS data type to use
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotation scan data VDS is 16-bit
2 participants