Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Use event data to create beam and attenuator in nexus writer #1173

Closed
DominicOram opened this issue Feb 20, 2024 · 1 comment · Fixed by #1262
Closed

Use event data to create beam and attenuator in nexus writer #1173

DominicOram opened this issue Feb 20, 2024 · 1 comment · Fixed by #1262
Assignees
@DominicOram

Comments

@DominicOram
Copy link
Collaborator

DominicOram commented Feb 20, 2024 •
edited
Loading

Following #1172 we should refactor the nexus writing to use more of the event data from the plan. Specifically:

  • create_beam_and_attenuator_parameters should get data from events that are coming out of the plan with energy, transmission and flux.
  • This probably means it makes sense for the two nexus callbacks to have a common parent
  • Both should use the event data to replace any references to ispyb_params in the writer
@DominicOram DominicOram mentioned this issue Feb 20, 2024
Merged
@DominicOram DominicOram changed the title Use more event data in nexus writing Use event data to create beam and attenuator in nexus writer Mar 11, 2024
@DominicOram
Copy link
Collaborator Author

We think 2 or 3 days

@DominicOram DominicOram self-assigned this Mar 15, 2024
DominicOram added a commit that referenced this issue Mar 15, 2024
@DominicOram
(#1173) Move beam and attenuattor creator into callbacks
53dc6b2
DominicOram added a commit that referenced this issue Mar 15, 2024
@DominicOram
(#1173) Create nexus file beam and attenuator based on events from ca…
2f4aa94 
…llback
@DominicOram DominicOram mentioned this issue Mar 15, 2024
Merged
DominicOram added a commit that referenced this issue Mar 15, 2024
@DominicOram
(#1173) Add required RE for tests
c4d6845
This was referenced Apr 3, 2024
Merged
Closed
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1173) Move beam and attenuattor creator …
3a25c9c 
…into callbacks
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1173) Create nexus file beam and attenua…
0b42feb 
…tor based on events from callback
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1173) Add required RE for tests
5285fa0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DominicOram DominicOram

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use event data for nexus writing DiamondLightSource/hyperion
1 participant
@DominicOram