-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ApertureScatterguard to return individual signals #769
Conversation
This then becomes a requirement for #679 |
9b61f5d
to
c471427
Compare
Making a Hyperion patchset now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
- Coverage 94.52% 94.52% -0.01%
==========================================
Files 115 115
Lines 4621 4599 -22
==========================================
- Hits 4368 4347 -21
+ Misses 253 252 -1 ☔ View full report in Codecov by Sentry. |
38dc19c
to
7080485
Compare
0f2ce23
to
88ce04c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks
aperture_z: float | ||
scatterguard_x: float | ||
scatterguard_y: float | ||
radius: float | None = Field(json_schema_extra={"units": "µm"}, default=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
I think this is a definite issue, made #782. Feel free to comment on there if you disagree. |
Fixes an issue discovered as part of #679, bluesky/ophyd-async#550 (comment) : SoftConverter is no longer exported from ophyd_async as of 0.5.0, and @coretl @danielballan think that bluesky/ophyd-async#310 should not include being able to pass arbitrary objects, only those that are tableable [tabulable? tabulatable?]. This change therefore adjusts how the ApertureScatterguard returns its signals to be nested under its child devices but as invidual signals.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}