-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DiamondLightSource/mx-bluesky#475) Method to allow access to full zocalo results #814
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #814 +/- ##
==========================================
- Coverage 95.20% 95.19% -0.01%
==========================================
Files 120 120
Lines 4985 4997 +12
==========================================
+ Hits 4746 4757 +11
- Misses 239 240 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The consensus in ophyd_async
is to move away from arbitrary types on signals. I have made bluesky/ophyd-async#601 to actually try and advertise this fact. We should probably refactor this to use individual signals rather than XRCResults
, like we did for #769.
Additionally, I think after this PR get_processing_result
is no longer used, can we remove it?
97e21f2
to
65bf6a3
Compare
Remove composite results signal
65bf6a3
to
303869f
Compare
Requested changes were adressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approving, not merging until DiamondLightSource/mx-bluesky#553 is ready
This PR now obsoleted by #858 |
With #858 merged I think this is now redundant so closing |
Extends ZocaloResults to get access to everything instead of just the position and bounding box
Fixes DiamondLightSource/mx-bluesky#475