Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement in networks module #271

Merged
merged 12 commits into from
Sep 16, 2022
Merged

Improvement in networks module #271

merged 12 commits into from
Sep 16, 2022

Conversation

Mec-iS
Copy link
Contributor

@Mec-iS Mec-iS commented Sep 7, 2022 •
edited
Loading

As per #267 (review):

  • remove skn from dependencies, networkx is the reference library
  • implement distance using scipy.pdist with euclidian metric
  • other dependencies are not pinned (except scikit-learn as explained in Starting graph algebra #267 (comment) )
  • add a graph algebra notebook

@Mec-iS Mec-iS requested a review from ceteri September 7, 2022 10:00
@Mec-iS Mec-iS mentioned this pull request Sep 7, 2022
Closed
@Mec-iS Mec-iS changed the title Improvement in networks modules Improvement in networks module Sep 7, 2022
@Mec-iS Mec-iS mentioned this pull request Sep 7, 2022
Merged
@tomaarsen
Copy link
Collaborator

Are you using pre-commit? It should lint automatically for you, among other things. As simple as pre-commit install.

ceteri
ceteri approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@ceteri ceteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @Mec-iS !
Lots of great catches in there!

@ceteri ceteri merged commit 48130af into main Sep 16, 2022
@Mec-iS Mec-iS deleted the issue-261-graph-algebra branch September 17, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceteri ceteri ceteri approved these changes

@tomaarsen tomaarsen Awaiting requested review from tomaarsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mec-iS @tomaarsen @ceteri