Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting graph algebra #267

Merged
merged 14 commits into from
Sep 6, 2022
Merged

Conversation

Mec-iS
Copy link
Contributor

@Mec-iS Mec-iS commented Sep 5, 2022

First PR for #261

Please suggest how to proceed. For now I have implemented conversions to numpy.array, which metrics/algorithms would you like to see computed?

Please consider writing notebooks that use these functionalities.

cc: @tomaarsen @ceteri @SultanOrazbayev

Copy link
Collaborator

@ceteri ceteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mec-iS Mec-iS marked this pull request as ready for review September 6, 2022 10:44
@Mec-iS Mec-iS merged commit 1c78a6a into DerwenAI:main Sep 6, 2022
@Mec-iS Mec-iS deleted the issue-261-graph-algebra branch September 6, 2022 16:31
Copy link
Collaborator

@ceteri ceteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good!
Two questions:

  1. Dependencies numpy, sklearn, skn are pegged to specific point releases. Do they need to be? Previously, this caused lots of compatibility problems since people on different platforms (e.g., Windows) working on different specific use cases (other dependencies) ran into many conflicts, since they required specific point releases. Is there a way to use ranges instead?
  2. For network analysis, is there any trade-off comparison of using these approaches (e.g., with skn) versus using NetworkX? If we use NetworkX then we can often pickup paths for better performance using GPUs (RAPIDS) and scale.

@Mec-iS
Copy link
Contributor Author

Mec-iS commented Sep 7, 2022

  1. These are the current dependencies situation: scikit-learn has to be pinned to current stable version 1 as when the current nightly version 2 will come out there may be breaking changes, skn requires numpy==1.23.0. For Windows users, may be useful to suggest using Anaconda or implement the usage of poetry that I was thinking about implementing anyway.
  2. Yes you are right. I thought to use skn as the API is very user-friendly and similar to the very popular scikit-learn, in terms of GPU support networkx is probably better.

I will open issues for some of the above, let me know which ones.

@Mec-iS
Copy link
Contributor Author

Mec-iS commented Sep 7, 2022

@ceteri #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants