-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting graph algebra #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mec-iS
force-pushed
the
issue-261-graph-algebra
branch
from
September 5, 2022 14:02
e506265
to
80e04b4
Compare
ceteri
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
ceteri
requested changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good!
Two questions:
- Dependencies
numpy
,sklearn
,skn
are pegged to specific point releases. Do they need to be? Previously, this caused lots of compatibility problems since people on different platforms (e.g., Windows) working on different specific use cases (other dependencies) ran into many conflicts, since they required specific point releases. Is there a way to use ranges instead? - For network analysis, is there any trade-off comparison of using these approaches (e.g., with skn) versus using NetworkX? If we use NetworkX then we can often pickup paths for better performance using GPUs (RAPIDS) and scale.
I will open issues for some of the above, let me know which ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR for #261
Please suggest how to proceed. For now I have implemented conversions to
numpy.array
, which metrics/algorithms would you like to see computed?Please consider writing notebooks that use these functionalities.
cc: @tomaarsen @ceteri @SultanOrazbayev