Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1428 : remove deprecated code #910

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Sep 16, 2024

Description

Remove multiple REST endpoints, and fields of model classes that were deprecated in v4.x (i.e. via @deprecated annotation).

Addressed Issue

DependencyTrack/hyades#1428

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Copy link

codacy-production bot commented Sep 17, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5e6e15c) 21356 17569 82.27%
Head commit (5b3d909) 21312 (-44) 17530 (-39) 82.25% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#910) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro added this to the 5.6.0 milestone Sep 18, 2024
@sahibamittal sahibamittal merged commit 9969486 into main Sep 18, 2024
9 checks passed
@sahibamittal sahibamittal deleted the issue-1428-remove-deprecated-endpoints branch September 18, 2024 11:37
nscuro added a commit that referenced this pull request Sep 19, 2024
`/api/v1/bom/{token}` was deprecated in v4.11 and removed in #910.

Since BOM upload progress is tracked in durable workflows in v5, the new `event` endpoint must be adapted to check those as well.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit to DependencyTrack/hyades that referenced this pull request Sep 19, 2024
…ests

The `/api/v1/bom/{token}` endpoint was removed in DependencyTrack/hyades-apiserver#910

Signed-off-by: nscuro <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants