-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port: Add support for component properties + @ValidUuid
#712
Conversation
Co-Authored-By: Robert Kesteson <[email protected]> Co-Authored-By: Niklas <[email protected]>
src/main/java/org/dependencytrack/parser/cyclonedx/util/ModelConverter.java
Outdated
Show resolved
Hide resolved
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
@ValidUuid
@ValidUuid
@ValidUuid
@sahibamittal Is this intended to cover DependencyTrack/dependency-track#3590 already? There are a few more changes in that PR that are not included here. |
No I didn't check that PR, do you want me to include it in this PR? Since almost all changes are here already. |
I don't have a strong opinion on whether it should be included here. My main concern is that we don't skip it because The |
Yes, then I'll create a separate following PR for this change. I'll take that up now. |
Awesome, thank you! Then I'll merge this one. |
Description
Adds support for component properties, similar to how project properties are supported already.
On top of being manageable via REST API, component properties are also ingested upon BOM upload.
Adds support for custom annotation
@ValidUuid
.Addressed Issue
Backport change DependencyTrack/hyades#1190
Checklist