Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Add support for component properties + @ValidUuid #712

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jun 11, 2024

Description

Adds support for component properties, similar to how project properties are supported already.

On top of being manageable via REST API, component properties are also ingested upon BOM upload.

Adds support for custom annotation @ValidUuid.

Addressed Issue

Backport change DependencyTrack/hyades#1190

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added v4-port PRs that were ported from the Dependency-Track v4.x code base enhancement New feature or request labels Jun 11, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 86.14% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (67f45f0) 19674 16033 81.49%
Head commit (a2d622a) 19876 (+202) 16200 (+167) 81.51% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#712) 202 174 86.14%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro changed the title Backport : support for component properties + @ValidUuid Port: Support for component properties + @ValidUuid Jun 11, 2024
@nscuro nscuro changed the title Port: Support for component properties + @ValidUuid Port: Add support for component properties + @ValidUuid Jun 11, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 11, 2024
@nscuro
Copy link
Member

nscuro commented Jun 11, 2024

@sahibamittal Is this intended to cover DependencyTrack/dependency-track#3590 already? There are a few more changes in that PR that are not included here.

@sahibamittal
Copy link
Collaborator Author

@sahibamittal Is this intended to cover DependencyTrack/dependency-track#3590 already? There are a few more changes in that PR that are not included here.

No I didn't check that PR, do you want me to include it in this PR? Since almost all changes are here already.

@nscuro
Copy link
Member

nscuro commented Jun 11, 2024

I don't have a strong opinion on whether it should be included here. My main concern is that we don't skip it because @ValidUuid was already ported.

The ConstraintViolationExceptionMapper in DependencyTrack/dependency-track#3590 is important for how @ValidUuid will behave. And the format = "uuid" addition for @ApiParam method parameters are important for how the Swagger is rendered.

@sahibamittal
Copy link
Collaborator Author

I don't have a strong opinion on whether it should be included here. My main concern is that we don't skip it because @ValidUuid was already ported.

The ConstraintViolationExceptionMapper in DependencyTrack/dependency-track#3590 is important for how @ValidUuid will behave. And the format = "uuid" addition for @ApiParam method parameters are important for how the Swagger is rendered.

Yes, then I'll create a separate following PR for this change. I'll take that up now.

@nscuro
Copy link
Member

nscuro commented Jun 11, 2024

Awesome, thank you! Then I'll merge this one.

@nscuro nscuro merged commit 6f0ae88 into main Jun 11, 2024
9 checks passed
@nscuro nscuro deleted the backport-support-for-component-properties branch June 11, 2024 16:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants