Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Apply consistent formatting to SQL query #709

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jun 10, 2024

Description

Applies consistent formatting to SQL queries, and utilizes Java text blocks instead of string concatenation for multi-line queries.

Addressed Issue

Backport change DependencyTrack/hyades#1190

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added defect Something isn't working v4-port PRs that were ported from the Dependency-Track v4.x code base labels Jun 10, 2024
@nscuro
Copy link
Member

nscuro commented Jun 10, 2024

The original PR modified queries that were introduced in DependencyTrack/dependency-track#2472. Either we wait until that PR is ported, or we make sure to apply the same formatting when we port it.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.04% (target: -1.00%) 83.33% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cd97399) 19631 16003 81.52%
Head commit (e5cfb8d) 19631 (+0) 15996 (-7) 81.48% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#709) 6 5 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro changed the title Backport : Apply consistent formatting to SQL query Port: Apply consistent formatting to SQL query Jun 11, 2024
@nscuro nscuro added this to the 5.5.0 milestone Jun 11, 2024
@nscuro nscuro merged commit 67f45f0 into main Jun 11, 2024
9 checks passed
@nscuro nscuro deleted the port-sql-query-formatting branch June 11, 2024 10:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Something isn't working v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants