Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Preprocess CWE dictionary #688

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Port: Preprocess CWE dictionary #688

merged 1 commit into from
Jun 4, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 28, 2024

Description

Ports DependencyTrack/dependency-track#3284 from Dependency-Track v4.11.0

Addressed Issue

Relates to DependencyTrack/hyades#1190

Additional Details

Instead of using the Python script from the original PR, I ported the script to JBang and published it to Dependency-Track's JBang catalog. At the moment, the functionality of this script is needed in 3 repos (dependency-track, hyades, hyades-apiserver), so keeping it centrally makes more sense.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels May 28, 2024
@nscuro nscuro added this to the 5.5.0 milestone May 28, 2024
Copy link

codacy-production bot commented May 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+1.35% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c5cb3d3) 18212 14590 80.11%
Head commit (75a2a95) 19568 (+1356) 15940 (+1350) 81.46% (+1.35%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#688) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

nscuro added a commit to DependencyTrack/hyades that referenced this pull request May 28, 2024
Removes the `generate-cwe-definitions.py` in favor of the `gen-cwe-dict` JBang script: https://github.com/DependencyTrack/jbang-catalog/blob/main/GenerateCweDictionary.java

Regenerates the CWE dictionary using the new script for consistency. It is now identical to the file included in DependencyTrack/hyades-apiserver#688

Signed-off-by: nscuro <[email protected]>
Ports DependencyTrack/dependency-track#3284 from Dependency-Track v4.11.0

Instead of using the Python script from the original PR, I ported the script to JBang and published it to Dependency-Track's JBang catalog. At the moment, the functionality of this script is needed in 3 repos (`dependency-track`, `hyades`, `hyades-apiserver`), so keeping it centrally makes more sense.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro merged commit 4a0987b into main Jun 4, 2024
8 checks passed
@nscuro nscuro deleted the port-pr-3284 branch June 4, 2024 13:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants