-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port: Add "Show in Dependency-Graph" Button in "Affected Projects" List #671
Conversation
Co-authored-by: RBickert <[email protected]> Signed-off-by: leec94 <[email protected]>
Co-authored-by: RBickert <[email protected]> Signed-off-by: leec94 <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
src/main/java/org/dependencytrack/persistence/VulnerabilityQueryManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: leec94 <[email protected]>
Signed-off-by: leec94 <[email protected]>
src/main/java/org/dependencytrack/persistence/VulnerabilityQueryManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: leec94 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leec94!
Description
Porting issue
Add "Show in Dependency-Graph" Button in "Affected Projects" List
: DependencyTrack/dependency-track#3285Addressed Issue
Porting features from v4.11, working on overall issue: DependencyTrack/hyades#1190
Additional Details
VulnerabilityQueryManager.java
was tricky to port the changes,getProjects
had a decent amount of changes so I wasn't sure where to put the line changes. I ended up adding the changed functiongetAffectedProjects
in its entirely below the existing function. if there's advice on a better way to incorporate the changes i'm all earsChecklist