Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: Add "Show in Dependency-Graph" Button in "Affected Projects" List #671

Merged
merged 5 commits into from
May 29, 2024

Conversation

leec94
Copy link
Contributor

@leec94 leec94 commented May 3, 2024

Description

Porting issue Add "Show in Dependency-Graph" Button in "Affected Projects" List: DependencyTrack/dependency-track#3285

Addressed Issue

Porting features from v4.11, working on overall issue: DependencyTrack/hyades#1190

Additional Details

  • VulnerabilityQueryManager.java was tricky to port the changes, getProjects had a decent amount of changes so I wasn't sure where to put the line changes. I ended up adding the changed function getAffectedProjects in its entirely below the existing function. if there's advice on a better way to incorporate the changes i'm all ears

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

leec94 and others added 2 commits May 3, 2024 14:48
Co-authored-by: RBickert <[email protected]>
Signed-off-by: leec94 <[email protected]>
Co-authored-by: RBickert <[email protected]>
Signed-off-by: leec94 <[email protected]>
Copy link

codacy-production bot commented May 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% (target: -1.00%) 98.55% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (01c3387) 18050 14447 80.04%
Head commit (504de1e) 18118 (+68) 14510 (+63) 80.09% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#671) 69 68 98.55%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels May 21, 2024
@nscuro nscuro added this to the 5.5.0 milestone May 21, 2024
@nscuro nscuro changed the title port issue 3285 "Add "Show in Dependency-Graph" Button in "Affected Projects" List" Port: Add "Show in Dependency-Graph" Button in "Affected Projects" List May 21, 2024
Signed-off-by: leec94 <[email protected]>
Signed-off-by: leec94 <[email protected]>
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leec94!

@nscuro nscuro merged commit 81aa9cf into DependencyTrack:main May 29, 2024
10 checks passed
@leec94 leec94 deleted the issue-3285-showbutton branch May 29, 2024 13:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants